Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: Add some Variables and Descriptions which exist in templates but not in Values.yaml #2795

Closed
3 tasks done
lianneli opened this issue Apr 28, 2024 · 0 comments · Fixed by #2799
Closed
3 tasks done

[Improvement]: Add some Variables and Descriptions which exist in templates but not in Values.yaml #2795

lianneli opened this issue Apr 28, 2024 · 0 comments · Fixed by #2799
Labels
type:improvement

Comments

@lianneli
Copy link
Contributor

lianneli commented Apr 28, 2024 •
edited
Loading

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

I found some variables exists in templates but not in Values.yaml. We can add them with description into Values.yaml, to make others use more convenient.

How should we improve?

Add those variables into Value.yaml

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct
@lianneli lianneli changed the title [Improvement]: Add some Variables and Descriptions which exist in templates but not in Values.xml [Improvement]: Add some Variables and Descriptions which exist in templates but not in Values.yaml Apr 28, 2024
@lianneli lianneli mentioned this issue Apr 29, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AMORO2795][helm chart] add variables and descriptions into values.yaml lianneli/amoro
1 participant
@lianneli