-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMORO-1957] Support liveness port testing for standby instance #2134
Conversation
Codecov ReportAttention:
... and 4 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think using a separate port as a liveness port is not a good solution. If the goal is to solve the Kubernetes pod liveness probe issue, using the "ps" command is also a viable option. This PR proposes reusing the HTTP port and obtaining the instance status through an HTTP API.
Do you think using the HTTP API mentioned here #2082 is a resonable solution? @baiyangtx |
Maybe take a look at this: |
Can this interface be accessed on standby nodes? @wangtaohz |
I don't think it can, just like any other HTTP API, only the leader AMS provides HTTP service. |
Since this PR is not planed to proceed for now, can I close the PR temporarily? @huyuanfeng2018 |
ok |
Why are the changes needed?
Close ##1957
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
In my environment it works fine.
Documentation