Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2081] Add "/ams/v1/health/status" url to whitelist #2082

Merged
merged 9 commits into from
Oct 12, 2023

Conversation

ShawHee
Copy link
Contributor

@ShawHee ShawHee commented Oct 12, 2023

fix #2081

Why are the changes needed?

When using the "/ams/v1/health/status" url for health check, it was found that the whitelist was not added, making it difficult to use.

Brief change log

ams/server/src/main/java/com/netease/arctic/server/dashboard/DashboardServer.java

private static final String[] urlWhiteList = {
      "/ams/v1/versionInfo",
      "/ams/v1/login",
      "/ams/v1/health/status",
      "/",
      "/overview",
      "/introduce",
      "/tables",
      "/optimizers",
      "/login",
      "/terminal",
      "/hive-tables/upgrade",
      "/hive-tables",
      "/index.html",
      "/favicon.ico",
      "/js/*",
      "/img/*",
      "/css/*",
      IcebergRestCatalogService.ICEBERG_REST_API_PREFIX + "/*"
  };

add /ams/v1/health/status to whitelist

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no) no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...tease/arctic/server/dashboard/DashboardServer.java 65.78% <ø> (ø)

... and 48 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@wangtaohz wangtaohz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Avoiding authentication during health check is a reasonable requirement, thank you for your contribution! 👍

@shidayang
Copy link
Contributor

LGTM

@zhoujinsong zhoujinsong merged commit 8c7b003 into apache:master Oct 12, 2023
5 of 6 checks passed
@ShawHee ShawHee deleted the health_status branch October 12, 2023 07:24
ShawHee added a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
* fix close_wait problem in limit query

* add /ams/v1/health/status to whitelist

---------

Co-authored-by: Chao He <hechao@rd.netease.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Make health status checks available without logging in
4 participants