-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMORO-2081] Add "/ams/v1/health/status" url to whitelist #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
... and 48 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
wangtaohz
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Avoiding authentication during health check is a reasonable requirement, thank you for your contribution! 👍
shidayang
approved these changes
Oct 12, 2023
LGTM |
3 tasks
ShawHee
added a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
* fix close_wait problem in limit query * add /ams/v1/health/status to whitelist --------- Co-authored-by: Chao He <hechao@rd.netease.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2081
Why are the changes needed?
When using the "/ams/v1/health/status" url for health check, it was found that the whitelist was not added, making it difficult to use.
Brief change log
ams/server/src/main/java/com/netease/arctic/server/dashboard/DashboardServer.java
add /ams/v1/health/status to whitelist
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation