Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IVY-1495 #21

Merged
merged 1 commit into from
Jun 1, 2017
Merged

Fix IVY-1495 #21

merged 1 commit into from
Jun 1, 2017

Conversation

jaikiran
Copy link
Member

The commit here is a potential fix for the issue reported in https://issues.apache.org/jira/browse/IVY-1495. The issue happens when the ivysettings.xml is being parsed and the IvySettings instance isn't yet available for getting hold of a relevant matcher referred to in the ttl config.

The commit here delays the access to the matcher from the settings instance, to when the settings instance is available.

The commit also includes a test case to verify the change.

@jaikiran
Copy link
Member Author

jaikiran commented May 20, 2017

FWIW - the test failures don't look related. That WarnCircularDependencyStrategyTest testcase though probably needs to be looked into separately, since it keeps failing once in a while on Jenkins.

@jaikiran
Copy link
Member Author

That WarnCircularDependencyStrategyTest testcase though probably needs to be looked into separately, since it keeps failing once in a while on Jenkins.

I think this #22 should fix the transient test failures.

@jaikiran
Copy link
Member Author

Reopening this one

@asfgit asfgit merged commit 3d30c8c into apache:master Jun 1, 2017
asfgit pushed a commit that referenced this pull request Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants