Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite e2e test(ssl_test) with ginkgo #1526

Merged

Conversation

Jaycean
Copy link
Member

@Jaycean Jaycean commented Mar 1, 2021

Please answer these questions before submitting a pull request


New feature or improvement

  • Rewrite e2e test(ssl_test) with ginkgo

@codecov-io
Copy link

codecov-io commented Mar 1, 2021

Codecov Report

Merging #1526 (d75b79a) into master (93e55ec) will decrease coverage by 2.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1526      +/-   ##
==========================================
- Coverage   69.01%   66.84%   -2.18%     
==========================================
  Files          48       48              
  Lines        3056     3055       -1     
==========================================
- Hits         2109     2042      -67     
- Misses        707      783      +76     
+ Partials      240      230      -10     
Impacted Files Coverage Δ
...l/handler/route_online_debug/route_online_debug.go 5.88% <0.00%> (-68.63%) ⬇️
api/internal/core/entity/entity.go 81.25% <0.00%> (-18.75%) ⬇️
api/internal/filter/schema.go 42.01% <0.00%> (-13.45%) ⬇️
api/internal/core/store/storehub.go 70.40% <0.00%> (-4.09%) ⬇️
api/internal/core/storage/etcd.go 47.27% <0.00%> (-3.64%) ⬇️
api/internal/core/store/store.go 86.74% <0.00%> (-1.21%) ⬇️
api/internal/utils/utils.go 64.70% <0.00%> (-1.18%) ⬇️
api/internal/handler/ssl/ssl.go 68.20% <0.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93e55ec...d75b79a. Read the comment docs.

@Jaycean Jaycean force-pushed the rewrite_e2e_test_ssl_test_with_ginkgo branch 2 times, most recently from 51629f6 to 57fa997 Compare March 2, 2021 00:04
@Jaycean Jaycean force-pushed the rewrite_e2e_test_ssl_test_with_ginkgo branch from 57fa997 to 0ce9444 Compare March 2, 2021 01:15
@nic-chen nic-chen merged commit c775e3e into apache:master Mar 3, 2021
@nic-chen
Copy link
Member

nic-chen commented Mar 3, 2021

merged. thanks a lot! @Jaycean

@Jaycean Jaycean deleted the rewrite_e2e_test_ssl_test_with_ginkgo branch March 10, 2021 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants