Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor test can-skip-upstream-when-select-service-id.spec.js #1859

Merged
merged 2 commits into from
May 17, 2021
Merged

chore: refactor test can-skip-upstream-when-select-service-id.spec.js #1859

merged 2 commits into from
May 17, 2021

Conversation

iamayushdas
Copy link
Contributor

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Refactor

What changes will this PR take into?

Refactor Testcase for Frontend.

Related issues

related issue #1774

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented May 7, 2021

Deploy preview for apisix-dashboard ready!

Built with commit d7749d6

https://deploy-preview-1859--apisix-dashboard.netlify.app

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2021

Codecov Report

Merging #1859 (d7749d6) into master (b1e66a2) will decrease coverage by 3.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1859      +/-   ##
==========================================
- Coverage   72.10%   68.85%   -3.26%     
==========================================
  Files         125      122       -3     
  Lines        2947     3111     +164     
  Branches      711      745      +34     
==========================================
+ Hits         2125     2142      +17     
- Misses        822      969     +147     
Flag Coverage Δ
frontend-e2e-test 68.85% <ø> (-3.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/pages/Route/Create.tsx 84.55% <0.00%> (-6.44%) ⬇️
web/src/pages/Route/components/Step3/index.tsx 51.85% <0.00%> (-1.72%) ⬇️
web/src/pages/Route/constants.ts 100.00% <0.00%> (ø)
...nts/PluginOrchestration/components/SidebarItem.tsx
...rc/components/PluginOrchestration/customConfig.tsx
...components/PluginOrchestration/components/Page.tsx
.../components/PluginOrchestration/DrawPluginStyle.ts
web/src/components/PluginOrchestration/service.ts
web/src/components/PluginOrchestration/index.tsx
...eb/src/components/PluginOrchestration/transform.ts
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e66a2...d7749d6. Read the comment docs.

@LiteSun LiteSun merged commit b43be5a into apache:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants