-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE: refactor Testcase files #1774
Comments
@guoqqqi, could you please guide @iamayushdas to complete the first issue? We have test cases that reference a public selector file, now we need to move them from that file to each test case file. Example:
|
Going to do this today, will take help from @guoqqqi if he will be free |
OK, I will assist him with the first question. |
ok, and @iamayushdas, I would prefer 1 test case file 1 PR :) That will help reviewers. |
We could list all files here that need to get updated, and then connect PRs with this issue. |
also add task for adding test statement for closing notification where missing |
oh, i didn't watch this comment, but i have added committed reconfigured tests one by one with suitable commit message, hope its ok? |
@guoqqqi i am done with all the tests except |
@iamayushdas |
I have done this , as it makes it easier for review and push changes efficiently as it is separated in different PRs |
Someone reports that you are spamming with "chore: refactored test ..." PRs via bot. But we can't merge all your 30s PR as it will cause misjudgment:
Or even worse:
|
I should apologize for criticizing your behavior. You are just doing what @juzhiyuan suggested:
However, looks like we didn't correctly estimate the number of PRs, and caused a misunderstanding. BTW, actually, it is not a good idea to split the PR in such size, because now we need more than 100 approvals to get the whole thing down and may cause misjudgment. As it is our fault, let's keep those PRs. |
Next time i will be cautious about it, sorry about all blunders and mistakes i have done. |
Hi @iamayushdas, that's not your fault, because the Review speed is slow those days, so there have many pending PRs (ready for review), this is our duty to move all those PRs forward. |
Okay 👍🏻 |
Feature request
Please describe your feature
Hi, this issue aims to improve Frontend's Testcases (Cypress.io).
Describe the solution you'd like
data value
directly instead of referringThe text was updated successfully, but these errors were encountered: