Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactored test create-route-with-cors-form.spec.js #1863

Merged
merged 2 commits into from
May 17, 2021
Merged

chore: refactored test create-route-with-cors-form.spec.js #1863

merged 2 commits into from
May 17, 2021

Conversation

iamayushdas
Copy link
Contributor

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Refactor

What changes will this PR take into?

Refactor Testcase for Frontend.

Related issues

related issue #1774

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented May 8, 2021

Deploy preview for apisix-dashboard ready!

Built with commit 1512d26

https://deploy-preview-1863--apisix-dashboard.netlify.app

@guoqqqi
Copy link
Member

guoqqqi commented May 12, 2021

There are some conflicts to be resolved here

@iamayushdas
Copy link
Contributor Author

There are some conflicts to be resolved here

What are they?

@guoqqqi
Copy link
Member

guoqqqi commented May 12, 2021

You can see them here:
image

@iamayushdas iamayushdas deleted the test19 branch May 12, 2021 16:08
@iamayushdas iamayushdas restored the test19 branch May 12, 2021 16:13
@iamayushdas iamayushdas reopened this May 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2021

Codecov Report

Merging #1863 (1512d26) into master (c860170) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1863      +/-   ##
==========================================
+ Coverage   68.85%   68.91%   +0.06%     
==========================================
  Files         122      122              
  Lines        3111     3111              
  Branches      745      745              
==========================================
+ Hits         2142     2144       +2     
+ Misses        969      967       -2     
Flag Coverage Δ
frontend-e2e-test 68.91% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/helpers.tsx 72.13% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c860170...1512d26. Read the comment docs.

@iamayushdas
Copy link
Contributor Author

You can see them here:

image

Ohh i guess its due to the recent commit from plugin orchestration, i have fixed the conflict.

@LiteSun LiteSun merged commit 019b30d into apache:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants