Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactored test login.spec.js #1881

Merged
merged 3 commits into from
May 17, 2021
Merged

chore: refactored test login.spec.js #1881

merged 3 commits into from
May 17, 2021

Conversation

iamayushdas
Copy link
Contributor

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Refactor

What changes will this PR take into?

Refactor Testcase for Frontend.

Related issues

related issue #1774

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented May 8, 2021

Deploy preview for apisix-dashboard ready!

Built with commit 1fa05fb

https://deploy-preview-1881--apisix-dashboard.netlify.app

@codecov-commenter
Copy link

Codecov Report

Merging #1881 (01fc99f) into master (b1e66a2) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1881      +/-   ##
==========================================
+ Coverage   72.10%   72.17%   +0.06%     
==========================================
  Files         125      125              
  Lines        2947     2947              
  Branches      711      711              
==========================================
+ Hits         2125     2127       +2     
+ Misses        822      820       -2     
Flag Coverage Δ
frontend-e2e-test 72.17% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/helpers.tsx 72.13% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e66a2...01fc99f. Read the comment docs.

@iamayushdas
Copy link
Contributor Author

@liuxiran can you retrigger CI , as i have checked it again, everything is working fine
Screenshot from 2021-05-11 21-09-12

@liuxiran
Copy link
Contributor

@liuxiran can you retrigger CI , as i have checked it again, everything is working fine
Screenshot from 2021-05-11 21-09-12

Ok, retry CI. Mark the error: https://github.com/apache/apisix-dashboard/pull/1881/checks?check_run_id=2557014779, maybe it is an un stable case,need some time to fix it.

@LiteSun LiteSun merged commit eb7bd29 into apache:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants