chore: use json schema instead hard code #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wei Jiang <machowei01@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2399 +/- ##
==========================================
- Coverage 68.57% 64.19% -4.38%
==========================================
Files 131 58 -73
Lines 3421 4036 +615
Branches 828 0 -828
==========================================
+ Hits 2346 2591 +245
+ Misses 1075 1073 -2
- Partials 0 372 +372
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
starsz
reviewed
Apr 1, 2022
api/internal/core/store/storehub.go
Outdated
| } | ||
|
|
||
| if _, ok := hubsNeedCheckByCustomize[key]; ok { | ||
| validator, err := NewJsonSchemaValidator("customize." + string(key)) |
There was a problem hiding this comment.
Why not put this under "main"?
There was a problem hiding this comment.
schema.json is output from apisix, my idea is to use different names for distinguishing them
starsz
approved these changes
Apr 6, 2022
nic-chen
approved these changes
Apr 12, 2022
bzp2010
approved these changes
Apr 12, 2022
hongbinhsu
pushed a commit
to fitphp/apix-dashboard
that referenced
this pull request
May 24, 2022
* upstream: (28 commits) docs: update some tips in develop.md (apache#2451) fix: create upstream error when pass host is node and nodes without port (apache#2421) fix: correct data type of filed Active.checks.active.https_verify_certificate (apache#2422) feat: basic support Apache APISIX 2.13.0 (apache#2428) feat: add page reload judgment (apache#2370) docs: Update RPM install package link (apache#2439) docs: Remove hyperlinks from documents (apache#2431) chore(deps): bump actions/upload-artifact from 2 to 3 (apache#2423) fix: consumer without plugins causes page crashes (apache#2437) chore(deps): bump axios from 0.21.1 to 0.21.4 in /web (apache#2420) feat: Modify plugin preview page (apache#2359) chore(deps): bump moment from 2.29.1 to 2.29.2 in /web (apache#2418) chore: use json schema instead hard code (apache#2399) refactor: migrate route tests to e2enew (apache#2411) chore(deps): bump actions/setup-python from 2.3.2 to 3.1.1 (apache#2414) chore: update the year of copyright and fix typo (apache#2417) docs: update online playground url (apache#2416) chore: update README for online demo (apache#2404) refactor: migrate id compatible tests to e2enew (apache#2400) docs: fix invalid link (apache#2366) ... # Conflicts: # api/internal/route.go # web/src/components/Footer/index.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wei Jiang machowei01@gmail.com
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
use json schema instead hard code
What changes will this PR take into?
Related issues
fix/resolve #2372
Checklist: