Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate id compatible tests to e2enew #2400

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

SkyeYoung
Copy link
Member

@SkyeYoung SkyeYoung commented Apr 1, 2022

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

migrate id compatible tests to e2enew

Related issues

fix/resolve #

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #2400 (d018982) into master (2f1ebac) will decrease coverage by 4.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2400      +/-   ##
==========================================
- Coverage   68.57%   63.60%   -4.97%     
==========================================
  Files         131      189      +58     
  Lines        3421     7441    +4020     
  Branches      828      828              
==========================================
+ Hits         2346     4733    +2387     
- Misses       1075     2373    +1298     
- Partials        0      335     +335     
Flag Coverage Δ
backend-e2e-test-ginkgo 59.37% <ø> (?)
frontend-e2e-test 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/handler/global_rule/global_rule.go 68.11% <0.00%> (ø)
api/internal/handler/ssl/ssl.go 65.87% <0.00%> (ø)
api/internal/core/migrate/conflict.go 80.00% <0.00%> (ø)
api/internal/filter/recover.go 7.69% <0.00%> (ø)
api/internal/utils/consts/api_error.go 50.00% <0.00%> (ø)
api/internal/utils/closer.go 66.66% <0.00%> (ø)
...pi/internal/handler/plugin_config/plugin_config.go 63.10% <0.00%> (ø)
api/internal/core/store/validate_mock.go 0.00% <0.00%> (ø)
api/main.go 100.00% <0.00%> (ø)
api/internal/core/entity/entity.go 90.90% <0.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 162c5d7...d018982. Read the comment docs.

@bzp2010 bzp2010 merged commit 865c02a into apache:master Apr 6, 2022
hongbinhsu pushed a commit to fitphp/apix-dashboard that referenced this pull request May 24, 2022
* upstream: (28 commits)
  docs: update some tips in develop.md (apache#2451)
  fix: create upstream error when pass host is node and nodes without port (apache#2421)
  fix: correct data  type of filed Active.checks.active.https_verify_certificate (apache#2422)
  feat: basic support Apache APISIX 2.13.0 (apache#2428)
  feat: add page reload judgment (apache#2370)
  docs: Update RPM install package link (apache#2439)
  docs: Remove hyperlinks from documents (apache#2431)
  chore(deps): bump actions/upload-artifact from 2 to 3 (apache#2423)
  fix: consumer without plugins causes page crashes (apache#2437)
  chore(deps): bump axios from 0.21.1 to 0.21.4 in /web (apache#2420)
  feat: Modify plugin preview page (apache#2359)
  chore(deps): bump moment from 2.29.1 to 2.29.2 in /web (apache#2418)
  chore: use json schema instead hard code (apache#2399)
  refactor: migrate route tests to e2enew (apache#2411)
  chore(deps): bump actions/setup-python from 2.3.2 to 3.1.1 (apache#2414)
  chore: update the year of copyright and fix typo (apache#2417)
  docs: update online playground url (apache#2416)
  chore: update README for online demo (apache#2404)
  refactor: migrate id compatible tests to e2enew (apache#2400)
  docs: fix invalid link (apache#2366)
  ...

# Conflicts:
#	api/internal/route.go
#	web/src/components/Footer/index.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants