Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update some tips in develop.md #2451

Merged
merged 2 commits into from
May 23, 2022
Merged

Conversation

gymgym1212
Copy link
Contributor

@gymgym1212 gymgym1212 commented May 12, 2022

Signed-off-by: Yeming Gu yeminggood@gmail.com

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Add some tips into develop.md to improve comprehensibility.

  • advise to change the make-api address explicitly. Otherwise, an 403 forbidden error will be generated when logging in, because the API address cannot be found.
  • prompt the user to ignore gyp errors during yarn install

Related issues

fix/resolve #2427

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: Yeming Gu <yeminggood@gmail.com>
@juzhiyuan juzhiyuan requested a review from membphis May 21, 2022 03:21
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and @gymgym1212 pls fix the ci, it failed

@gymgym1212
Copy link
Contributor Author

LGTM, and @gymgym1212 pls fix the ci, it failed

Got it. I will fix the ci.

Signed-off-by: Yeming Gu <yeminggood@gmail.com>
@gymgym1212
Copy link
Contributor Author

"First-time contributors need a maintainer to approve running workflows."

@gymgym1212
Copy link
Contributor Author

"First-time contributors need a maintainer to approve running workflows."

Hi @juzhiyuan , can you approve these workflows?

@Baoyuantop Baoyuantop merged commit 967038f into apache:master May 23, 2022
hongbinhsu pushed a commit to fitphp/apix-dashboard that referenced this pull request May 24, 2022
* upstream: (28 commits)
  docs: update some tips in develop.md (apache#2451)
  fix: create upstream error when pass host is node and nodes without port (apache#2421)
  fix: correct data  type of filed Active.checks.active.https_verify_certificate (apache#2422)
  feat: basic support Apache APISIX 2.13.0 (apache#2428)
  feat: add page reload judgment (apache#2370)
  docs: Update RPM install package link (apache#2439)
  docs: Remove hyperlinks from documents (apache#2431)
  chore(deps): bump actions/upload-artifact from 2 to 3 (apache#2423)
  fix: consumer without plugins causes page crashes (apache#2437)
  chore(deps): bump axios from 0.21.1 to 0.21.4 in /web (apache#2420)
  feat: Modify plugin preview page (apache#2359)
  chore(deps): bump moment from 2.29.1 to 2.29.2 in /web (apache#2418)
  chore: use json schema instead hard code (apache#2399)
  refactor: migrate route tests to e2enew (apache#2411)
  chore(deps): bump actions/setup-python from 2.3.2 to 3.1.1 (apache#2414)
  chore: update the year of copyright and fix typo (apache#2417)
  docs: update online playground url (apache#2416)
  chore: update README for online demo (apache#2404)
  refactor: migrate id compatible tests to e2enew (apache#2400)
  docs: fix invalid link (apache#2366)
  ...

# Conflicts:
#	api/internal/route.go
#	web/src/components/Footer/index.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[doc] How about adding a line in the dev-doc to prompt developers to ignore the error about node-gyp?
4 participants