fix: advance matching in the route create page causes the page to crash #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My understanding of this issue is:
|
Codecov Report
@@ Coverage Diff @@
## master #2440 +/- ##
==========================================
+ Coverage 68.57% 68.80% +0.23%
==========================================
Files 131 131
Lines 3427 3427
Branches 831 833 +2
==========================================
+ Hits 2350 2358 +8
+ Misses 1077 1069 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Hi @Si-ege, we need E2E test for this change:
|
|
|
Hi @Si-ege, thank you for your contribution. For the E2E test section, we would prefer to create a new test case, meaning to write the test in a new |
Baoyuantop
reviewed
Apr 27, 2022
| cy.get(selector.value).type(data.value); | ||
| cy.contains('Confirm').click(); | ||
| cy.get(selector.rowcard).should('be.visible'); | ||
| cy.get(selector.rowcard).get('tr>td').eq(2).should('have.value', ''); |
There was a problem hiding this comment.
Should it show up as false here?
Baoyuantop
reviewed
Apr 28, 2022
| @@ -148,7 +148,8 @@ const MatchingRulesView: React.FC<RouteModule.Step1PassProps> = ({ | |||
| { | |||
| title: formatMessage({ id: 'page.route.reverse' }), | |||
| key: 'reverse', | |||
| render: (text: RouteModule.MatchingRule) => text.reverse.toString(), | |||
| render: (text: RouteModule.MatchingRule) => | |||
| text.reverse === undefined ? text.reverse : text.reverse.toString(), | |||
There was a problem hiding this comment.
I think it is more appropriate to set an initial value for reverse in the Form.
|
ping @Si-ege any update? |
…causes-the-page-to-crash
0x9be00ff1
approved these changes
May 26, 2022
Baoyuantop
approved these changes
May 27, 2022
guoqqqi
approved these changes
May 29, 2022
LiteSun
approved these changes
May 30, 2022
hongbinhsu
pushed a commit
to fitphp/apix-dashboard
that referenced
this pull request
Jun 16, 2022
* upstream/master: test: remove stale E2E cases (apache#2475) feat: basic support Apache APISIX 2.14.1 (apache#2464) fix: Users can create a Consumer in Dashboard without enabling the plugin (apache#2442) fix: change "Route List" to "Routes" (apache#2453) fix: advance matching in the route create page causes the page to crash (apache#2440) feat: release 2.13 (apache#2458) feat: support Turkish Language (apache#2452) # Conflicts: # web/package.json
Closed
bzp2010
pushed a commit
to bzp2010/apisix-dashboard
that referenced
this pull request
Oct 31, 2022
…sh (apache#2440) (cherry picked from commit 5e624a5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Please update this section with detailed description.
Related issues
fix/resolve #2438
1.fix matching in the route create page causes the page to crash
Checklist: