Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Turkish Language #2452

Merged
merged 4 commits into from
May 26, 2022
Merged

feat: support Turkish Language #2452

merged 4 commits into from
May 26, 2022

Conversation

anldrms
Copy link
Contributor

@anldrms anldrms commented May 12, 2022

This is the initial pull request for adding Turkish language offical support for Apisix Dashboard.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #2452 (cc6074c) into master (92f46d9) will decrease coverage by 1.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2452      +/-   ##
==========================================
- Coverage   70.27%   68.80%   -1.47%     
==========================================
  Files         189      131      -58     
  Lines        7492     3456    -4036     
  Branches      845      845              
==========================================
- Hits         5265     2378    -2887     
+ Misses       1922     1078     -844     
+ Partials      305        0     -305     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 68.80% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Upstream/service.ts 86.20% <0.00%> (-1.73%) ⬇️
...pi/internal/handler/system_config/system_config.go
api/internal/handler/route/route.go
api/internal/filter/recover.go
api/internal/log/zap.go
api/internal/utils/pid.go
api/internal/handler/server_info/server_info.go
api/internal/handler/data_loader/route_export.go
api/internal/core/storage/etcd.go
api/internal/core/entity/interface.go
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92f46d9...cc6074c. Read the comment docs.

@Baoyuantop
Copy link
Contributor

I see that some of the content is not translated completely, which may cause some problems, for example:
image

@anldrms
Copy link
Contributor Author

anldrms commented May 16, 2022

I see that some of the content is not translated completely, which may cause some problems, for example: image

Thanks for the feedback , i'll check it later today.

@anldrms
Copy link
Contributor Author

anldrms commented May 16, 2022

@Baoyuantop could you point it the location of missing ones? Cause i checked it but didnt find.

@Baoyuantop
Copy link
Contributor

@Baoyuantop could you point it the location of missing ones? Cause i checked it but didnt find.

They are under web/src/pages; for example, there is a locales folder under Route in this directory.

@anldrms
Copy link
Contributor Author

anldrms commented May 17, 2022

Could you check again :) I am apologies for trouble

@Baoyuantop
Copy link
Contributor

Nice job 👍 @anldrms, after verifying that it works, we may need to spend some time checking the accuracy of the translation.

Copy link
Contributor

@Baoyuantop Baoyuantop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codes LGTM! There is a CI issue that needs to be fixed:
image

@anldrms
Copy link
Contributor Author

anldrms commented May 23, 2022

LGTM

Thanks for the review. Is there anything to fix that on my side?

@Baoyuantop
Copy link
Contributor

LGTM

Thanks for the review. Is there anything to fix that on my side?

You can follow the hints in the screenshot above to make the fix, which is a spelling error.

@anldrms
Copy link
Contributor Author

anldrms commented May 24, 2022

Now its ok i guess there is no parallel in Turkish so i deleted from the sentence.

@juzhiyuan juzhiyuan changed the title Turkish Language support added feat: support Turkish Language May 25, 2022
@juzhiyuan juzhiyuan merged commit a0be631 into apache:master May 26, 2022
hongbinhsu pushed a commit to fitphp/apix-dashboard that referenced this pull request Jun 16, 2022
* upstream/master:
  test: remove stale E2E cases (apache#2475)
  feat: basic support Apache APISIX 2.14.1 (apache#2464)
  fix: Users can create a Consumer in Dashboard without enabling the plugin (apache#2442)
  fix: change "Route List" to "Routes" (apache#2453)
  fix: advance matching in the route create page causes the page to crash (apache#2440)
  feat: release 2.13 (apache#2458)
  feat: support Turkish Language (apache#2452)

# Conflicts:
#	web/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants