Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove stale E2E cases #2475

Merged
merged 3 commits into from
Jun 15, 2022
Merged

Conversation

bzp2010
Copy link
Contributor

@bzp2010 bzp2010 commented Jun 15, 2022

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Remove the obsolete E2E tests and keep only the new ginkgo implementation.

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #2475 (3f37c22) into master (8253586) will increase coverage by 9.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2475      +/-   ##
==========================================
+ Coverage   59.43%   68.78%   +9.34%     
==========================================
  Files         174      189      +15     
  Lines        6855     7489     +634     
  Branches      842      842              
==========================================
+ Hits         4074     5151    +1077     
+ Misses       2563     2040     -523     
- Partials      218      298      +80     
Flag Coverage Δ
backend-e2e-test-ginkgo 59.84% <ø> (?)
backend-unit-test 49.88% <ø> (-0.03%) ⬇️
frontend-e2e-test 68.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/storage/etcd.go 51.18% <0.00%> (ø)
api/internal/core/server/server.go 62.50% <0.00%> (ø)
api/cmd/version.go 57.14% <0.00%> (ø)
api/internal/core/server/store.go 25.00% <0.00%> (ø)
api/internal/core/migrate/dataset.go 53.03% <0.00%> (ø)
api/internal/core/server/http.go 56.52% <0.00%> (ø)
api/internal/core/migrate/migrate.go 76.19% <0.00%> (ø)
api/internal/handler/healthz/healthz.go 100.00% <0.00%> (ø)
api/internal/core/storage/storage_mock.go 0.00% <0.00%> (ø)
api/internal/core/migrate/conflict.go 80.00% <0.00%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8253586...3f37c22. Read the comment docs.

@juzhiyuan juzhiyuan merged commit 3b2c371 into apache:master Jun 15, 2022
@@ -29,6 +28,8 @@ import (
"strings"
"testing"

"github.com/shiningrush/droplet/data"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line can be removed.

hongbinhsu pushed a commit to fitphp/apix-dashboard that referenced this pull request Jun 16, 2022
* upstream/master:
  test: remove stale E2E cases (apache#2475)
  feat: basic support Apache APISIX 2.14.1 (apache#2464)
  fix: Users can create a Consumer in Dashboard without enabling the plugin (apache#2442)
  fix: change "Route List" to "Routes" (apache#2453)
  fix: advance matching in the route create page causes the page to crash (apache#2440)
  feat: release 2.13 (apache#2458)
  feat: support Turkish Language (apache#2452)

# Conflicts:
#	web/package.json
bzp2010 added a commit to bzp2010/apisix-dashboard that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants