Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hmac-auth authorization method #1035

Merged
merged 12 commits into from May 26, 2022

Conversation

fatpa
Copy link
Contributor

@fatpa fatpa commented May 22, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

#990

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2022

Codecov Report

Merging #1035 (a8ff442) into master (f6f0a3b) will increase coverage by 0.18%.
The diff coverage is 40.22%.

@@            Coverage Diff             @@
##           master    #1035      +/-   ##
==========================================
+ Coverage   30.82%   31.01%   +0.18%     
==========================================
  Files          74       74              
  Lines        8606     8780     +174     
==========================================
+ Hits         2653     2723      +70     
- Misses       5670     5763      +93     
- Partials      283      294      +11     
Impacted Files Coverage Δ
pkg/kube/translation/apisix_route.go 20.60% <0.00%> (-0.27%) ⬇️
pkg/kube/translation/plugin.go 57.54% <41.02%> (-12.76%) ⬇️
pkg/kube/translation/apisix_consumer.go 67.74% <60.00%> (-1.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f0a3b...a8ff442. Read the comment docs.

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please check the comments.

pkg/kube/apisix/apis/config/v2beta3/types.go Outdated Show resolved Hide resolved
samples/deploy/crd/v1/ApisixRoute.yaml Outdated Show resolved Hide resolved
samples/deploy/crd/v1/ApisixRoute.yaml Outdated Show resolved Hide resolved
samples/deploy/crd/v1/ApisixRoute.yaml Outdated Show resolved Hide resolved
samples/deploy/crd/v1/ApisixRoute.yaml Outdated Show resolved Hide resolved
samples/deploy/crd/v1/ApisixRoute.yaml Outdated Show resolved Hide resolved
samples/deploy/crd/v1/ApisixRoute.yaml Outdated Show resolved Hide resolved
samples/deploy/crd/v1/ApisixRoute.yaml Outdated Show resolved Hide resolved
test/e2e/suite-features/consumer.go Outdated Show resolved Hide resolved
@lingsamuel
Copy link
Member

lingsamuel commented May 23, 2022

This PR affects #989, which one should be merged first (the later one needs to be modified accordingly)? @tao12345666333

@tao12345666333
Copy link
Member

tao12345666333 commented May 23, 2022

@lingsamuel I think it's possible to merge #989 first and then merge this. let's move forward.

There are still some content in this PR that need to be modified.

@fatpa
Copy link
Contributor Author

fatpa commented May 24, 2022

I think I should compatible with the PR above first.

@tao12345666333
Copy link
Member

thanks

@fatpa
Copy link
Contributor Author

fatpa commented May 25, 2022

Please approve the workflows. @tao12345666333

@tao12345666333
Copy link
Member

approved. thanks

@fatpa
Copy link
Contributor Author

fatpa commented May 25, 2022

I have no idea about the failure of the suite-ingress.
Could you help me to see what happened to this error? @tao12345666333

@fatpa fatpa requested a review from tao12345666333 May 25, 2022 09:28
@tao12345666333
Copy link
Member

re-run all jobs.

I will finish review today, it's on my list. thanks

@tao12345666333 tao12345666333 self-assigned this May 25, 2022
@fatpa fatpa requested a review from tao12345666333 May 26, 2022 02:19
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One place needs to be modified, other parts LGTM

test/e2e/suite-features/consumer.go Outdated Show resolved Hide resolved
@fatpa fatpa requested a review from tao12345666333 May 26, 2022 07:37
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request help: support hmac-auth plugin for ApisixConsumer
4 participants