New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hmac-auth authorization method #1035
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1035 +/- ##
==========================================
+ Coverage 30.82% 31.01% +0.18%
==========================================
Files 74 74
Lines 8606 8780 +174
==========================================
+ Hits 2653 2723 +70
- Misses 5670 5763 +93
- Partials 283 294 +11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Please check the comments.
This PR affects #989, which one should be merged first (the later one needs to be modified accordingly)? @tao12345666333 |
@lingsamuel I think it's possible to merge #989 first and then merge this. let's move forward. There are still some content in this PR that need to be modified. |
I think I should compatible with the PR above first. |
thanks |
Please approve the workflows. @tao12345666333 |
approved. thanks |
I have no idea about the failure of the suite-ingress. |
re-run all jobs. I will finish review today, it's on my list. thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One place needs to be modified, other parts LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change:
What this PR does / why we need it:
#990
Pre-submission checklist: