Skip to content

Commit

Permalink
ARIES-254: The JMX blueprint bundle should not export the .impl.codec…
Browse files Browse the repository at this point in the history
… package but .codec package instead

git-svn-id: https://svn.apache.org/repos/asf/incubator/aries/trunk/jmx@923710 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
gnodet committed Mar 16, 2010
1 parent 47bf01c commit 13b3049
Show file tree
Hide file tree
Showing 29 changed files with 49 additions and 48 deletions.
3 changes: 2 additions & 1 deletion jmx-blueprint-bundle/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@
*
</Import-Package>
<Export-Package>
org.apache.aries.jmx.blueprint
org.apache.aries.jmx.blueprint;version="${pom.version}",
org.apache.aries.jmx.blueprint.codec;version="${pom.version}"
</Export-Package>
<Private-Package>
org.apache.aries.jmx.blueprint.impl*
Expand Down
2 changes: 1 addition & 1 deletion jmx-blueprint-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
<Bundle-SymbolicName>${pom.artifactId}</Bundle-SymbolicName>
<Bundle-Activator>org.apache.aries.jmx.blueprint.impl.Activator</Bundle-Activator>
<Export-Package>
org.apache.aries.jmx.blueprint.impl.codec*;version=${project.version}
org.apache.aries.jmx.blueprint.codec*;version=${project.version}
</Export-Package>
<_versionpolicy>[$(version;==;$(@)),$(version;+;$(@)))</_versionpolicy>
<_removeheaders>Ignore-Package,Include-Resource,Private-Package,Bundle-DocURL</_removeheaders>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import java.util.HashMap;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import java.util.Map;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import java.util.HashMap;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import java.util.HashMap;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import java.util.HashMap;
import java.util.Map;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import java.util.HashMap;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import java.util.HashMap;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import java.util.HashMap;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

public interface BPMetadata extends TransferObject{
// marker interface
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

public interface BPNonNullMetadata extends BPMetadata {
// marker interface
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import javax.management.openmbean.CompositeData;
import javax.management.openmbean.CompositeDataSupport;
Expand All @@ -27,11 +27,11 @@

public class BPNullMetadata implements BPMetadata {
public BPNullMetadata(CompositeData Null) {
//do nothing ?
//do nothing ?
}

public BPNullMetadata(NullMetadata Null) {
//do nothing ?
//do nothing ?
}

public CompositeData asCompositeData() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import java.util.HashMap;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import java.util.HashMap;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import java.util.Map;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import java.util.HashMap;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import java.util.Map;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import java.util.HashMap;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import java.util.Map;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import java.util.Map;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

public interface BPTarget extends BPNonNullMetadata{
// marker interface
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import java.util.HashMap;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import java.util.HashMap;
import java.util.Map;
Expand Down Expand Up @@ -70,25 +70,25 @@
*/

public class OSGiBlueprintEvent implements TransferObject{

private long bundleId;

private long extenderBundleId;

private int eventType;

private boolean replay;

private long timestamp;

private String[] dependencies;

private String exceptionMessage;


/**
* Construct an OSGiBlueprintEvent from the supplied <link>BlueprintEvent</link>
*
*
* @param event
* - the event to represent
*/
Expand All @@ -105,7 +105,7 @@ public OSGiBlueprintEvent(BlueprintEvent event) {
/**
* Construct an OSGiBlueprintEvent from the CompositeData representing the
* event
*
*
* @param data
* - the CompositeData representing the event.
*/
Expand All @@ -122,7 +122,7 @@ public OSGiBlueprintEvent(CompositeData data) {

/**
* Construct the OSGiBlueprintEvent
*
*
* @param bundleId
* @param extenderBundleId
* @param eventType
Expand All @@ -140,10 +140,10 @@ public OSGiBlueprintEvent(long bundleId, long extenderBundleId, int eventType, b
this.dependencies = dependencies;
this.exceptionMessage = exceptionMessage;
}

/**
* Answer the receiver encoded as CompositeData
*
*
* @return the CompositeData encoding of the receiver.
*/
@SuppressWarnings("boxing")
Expand All @@ -162,7 +162,7 @@ public CompositeData asCompositeData() {
throw new IllegalStateException("Cannot form blueprint event open data", e);
}
}

public long getBundleId() {
return bundleId;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import javax.management.openmbean.CompositeData;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.aries.jmx.blueprint.impl.codec;
package org.apache.aries.jmx.blueprint.codec;

import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
Expand Down Expand Up @@ -87,7 +87,7 @@ public static BPMetadata metadata2BPMetadata(Metadata metadata) {
public static BPMetadata binary2BPMetadata(byte[] buf) {
if(null == buf)
return null;

ByteArrayInputStream inBytes = new ByteArrayInputStream(buf);
ObjectInputStream inObject;
CompositeData metadata;
Expand Down Expand Up @@ -146,7 +146,7 @@ public static BPMetadata binary2BPMetadata(byte[] buf) {
public static byte[] bpMetadata2Binary(BPMetadata metadata) {
if(null == metadata)
return null;

ByteArrayOutputStream outBytes = new ByteArrayOutputStream();
ObjectOutputStream outObject;
try {
Expand All @@ -163,7 +163,7 @@ public static Byte[] bpMetadata2BoxedBinary(BPMetadata metadata)
{
if(null == metadata)
return null;

byte [] src = bpMetadata2Binary(metadata);
Byte [] res = new Byte[src.length];
for(int i=0;i<src.length;i++)
Expand All @@ -175,7 +175,7 @@ public static Byte[] bpMetadata2BoxedBinary(BPMetadata metadata)
public static BPMetadata boxedBinary2BPMetadata(Byte[] buf) {
if(null == buf)
return null;

byte [] unbox = new byte[buf.length];
for(int i=0;i<buf.length;i++)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
import javax.management.openmbean.CompositeData;

import org.apache.aries.jmx.blueprint.BlueprintMetadataMBean;
import org.apache.aries.jmx.blueprint.impl.codec.BPMetadata;
import org.apache.aries.jmx.blueprint.impl.codec.Util;
import org.apache.aries.jmx.blueprint.codec.BPMetadata;
import org.apache.aries.jmx.blueprint.codec.Util;
import org.osgi.framework.Bundle;
import org.osgi.framework.BundleContext;
import org.osgi.framework.Constants;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
import javax.management.openmbean.TabularDataSupport;

import org.apache.aries.jmx.blueprint.BlueprintStateMBean;
import org.apache.aries.jmx.blueprint.impl.codec.OSGiBlueprintEvent;
import org.apache.aries.jmx.blueprint.codec.OSGiBlueprintEvent;
import org.osgi.framework.BundleContext;
import org.osgi.framework.ServiceRegistration;
import org.osgi.service.blueprint.container.BlueprintEvent;
Expand Down
2 changes: 1 addition & 1 deletion jmx-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
</Import-Package>
<!-- Not currently exporting anything -->
<Export-Package>
org.apache.aries.jmx.codec;;version=${project.version}
org.apache.aries.jmx.codec;version=${project.version}
</Export-Package>
<_versionpolicy>[$(version;==;$(@)),$(version;+;$(@)))</_versionpolicy>
<_removeheaders>Ignore-Package,Include-Resource,Private-Package,Bundle-DocURL</_removeheaders>
Expand Down

0 comments on commit 13b3049

Please sign in to comment.