ARIES-1650 Optionally exclude non bundle artifacts in ESA maven plugin

[wb459]

Implementation for ARIES-1650
Made the new feature optional (by default disabled)

[bosschaert]

When I apply this as a patch to the aries codebase I get the following test failure:

Tests run: 12, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.713 sec <<< FAILURE! - in org.apache.aries.plugin.esa.EsaMojoTest
testBasicEsaWithoutNonBundleJars(org.apache.aries.plugin.esa.EsaMojoTest)  Time elapsed: 0.024 sec  <<< ERROR!
java.lang.IllegalArgumentException: UTIL0016E: The path /Users/David/checkouts/aries/esa-maven-plugin/src/test/remote-repo/org/apache/maven/test/maven-artifact05-no-bundle-manifest/1.1-SNAPSHOT/maven-artifact05-no-bundle-manifest-1.1-SNAPSHOT.jar does not denote a valid file.
	at org.apache.aries.util.manifest.BundleManifest.fromBundle(BundleManifest.java:133)
	at org.apache.aries.plugin.esa.EsaMojo.isNonJarOrOSGiBundle(EsaMojo.java:572)
	at org.apache.aries.plugin.esa.EsaMojo.selectNonJarArtifactsAndBundles(EsaMojo.java:559)
	at org.apache.aries.plugin.esa.EsaMojo.addDependenciesToArchive(EsaMojo.java:243)
	at org.apache.aries.plugin.esa.EsaMojo.execute(EsaMojo.java:620)
	at org.apache.aries.plugin.esa.EsaMojoTest.testBasicEsaWithoutNonBundleJars(EsaMojoTest.java:433)

[wb459]

@bosschaert

Do you have the same issue when running the test suit with maven?

[bosschaert]

@WouterBanckenACA Yes this is when I run it using maven from the commandline.
Basically what I did was apply this pull request as a patch (from https://github.com/apache/aries/pull/63.patch) and then run mvn install.

My environment:

$ mvn -version
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00)
Java version: 1.8.0_112, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_112.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.11.6", arch: "x86_64", family: "mac"

[tomdw]

@bosschaert I merged in the changes from trunk into the pull request and adapted the jars that provided problems. Can you try again? if it still persists then it might be a problem with the 'patch' functionality of github not handling binary files correctly?