-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore Updating VariadicAny Signature to take 0 Args #11522
Comments
Does that work for your use case? I vaguely remember datafusion/datafusion/expr/src/signature.rs Lines 116 to 118 in b0925c8
|
That's actually what I did do in datafusion/datafusion/functions-aggregate/src/count.rs Lines 98 to 102 in b197449
|
The reason is that we currently use |
Is your feature request related to a problem or challenge?
Currently
VariadicAny
represents 1 or more arguments, but given the name and seemingly intention, it seems like 0 or more would make more sense (though there a number of counter examples).See https://github.com/apache/datafusion/pull/11229/files#r1680888279 for more discussion.
Describe the solution you'd like
VariadicAny
is updated to support 0 arguments.Describe alternatives you've considered
See the linked discussion for a few alternatives. It's unclear if
VariadicAny
w/ 0 args is the best option here, but was an issue implementingCOUNT()
.Additional context
datafusion/datafusion/expr/src/signature.rs
Lines 100 to 101 in b0925c8
The text was updated successfully, but these errors were encountered: