-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert target columns empty fix #5079
Insert target columns empty fix #5079
Conversation
21e76c4
to
a2f63cc
Compare
@@ -323,7 +323,7 @@ pub struct ConfigOptions { | |||
pub catalog: CatalogOptions, | |||
/// Execution options | |||
pub execution: ExecutionOptions, | |||
/// Explain options | |||
/// Optimizer options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ Nice drive by cleanup
@@ -165,13 +165,60 @@ fn plan_insert() { | |||
"insert into person (id, first_name, last_name) values (1, 'Alan', 'Turing')"; | |||
let plan = r#" | |||
Dml: op=[Insert] table=[person] | |||
Projection: CAST(column1 AS id AS UInt32), column2 AS first_name, column3 AS last_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This makes sense to me -- thank you @gruuya |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Benchmark runs are scheduled for baseline = 842bda3 and contender = 3133526. 3133526 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #5078.
Rationale for this change
Enable logical planning of
INSERT
statements without the optional target column list.What changes are included in this PR?
If there are no parsed target fields in the
INSERT
statement default to using all the fields from the table's schema.Are these changes tested?
Yes.
Are there any user-facing changes?
Only to users that use Datafusion as a framework where write statements are supported.