-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor: port date_bin tests to sqllogictests #5115
Conversation
FYI @stuartcarnie as the original author of these tests |
f06ad3c
to
f198aa1
Compare
Very nice – looks like the test files are YAML? |
The test files are actually sqllite style "sqllogictest" files -- details on the format can be found in https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/tests/sqllogictests/README.md |
@xudong963 or @melgenek could I trouble one of you for a review of this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it would be nice to understand if Datafusion wants to have type checks in sqllogictest at all.
Otherwise, query <LETTER>
don't mean much for now. For example, the letter T
is supposed to be "text" in sqllogictest.
It is probably easier to go DuckDBs way and check only the number of columns. And rely on arrow_type
for type checks.
I think adding this verification is tracked in #4499 - it seems like a valuable addition to me, but I haven't gotten around to implement it yet. I agree having a bunch of letters that look like they are checked but are silently ignored is probably worse than not having them at all
That would be fine with me too |
Co-authored-by: xudong.w <wxd963996380@gmail.com>
Benchmark runs are scheduled for baseline = bd64527 and contender = 11e8906. 11e8906 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Part of #4853
Rationale for this change
I plan to add some additional coercion for date_bin and I want to write the tests using sqllogictest. This PR moves the test. I will build on this PR for #4853
What changes are included in this PR?
port
date_bin
test to use sqllogictest frameworkAre these changes tested?
yes (they are tests)
Are there any user-facing changes?
no