Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rust and point integration tests to arrow-rs repo #211

Closed
alamb opened this issue Apr 26, 2021 · 2 comments
Closed

Remove Rust and point integration tests to arrow-rs repo #211

alamb opened this issue Apr 26, 2021 · 2 comments
Labels
arrow Changes to the arrow crate

Comments

@alamb
Copy link
Contributor

alamb commented Apr 26, 2021

Note: migrated from original JIRA: https://issues.apache.org/jira/browse/ARROW-12444

Goals:

  • Make integration tests run against arrow-rs@master
  • Remove Rust from apache/arrow

Tasks:

  • Remove Rust from CI
  • Remove rust/
  • git clone apache/arrow-rs@master in integration tests
  • remove rust from Archery Lint
  • remove rust from PR labeler
  • remove rust from detect_changes.py
@alamb alamb added the arrow Changes to the arrow crate label Apr 26, 2021
@alamb
Copy link
Contributor Author

alamb commented Apr 26, 2021

Comment from Jorge Leitão(jorgecarleitao) @ 2021-04-19T04:07:08.720+0000:

cc [~andygrove] [~wes] [~alamb] [~kszucs]

Comment from Andrew Lamb(alamb) @ 2021-04-19T09:50:11.144+0000:

I recommend that we make integration tests from apache/arrow@master run against a specific pin of arrow-rs rather than master. The rationale being that if integration runs always against master unintentional breakages to arrow can be introduced at seemingly random times, leading to frustration and harder to debug errors

With the specific pin approach we will have to increase the pin at some period of time, but we will have control over the schedule and will know exactly what versions were tested to be compatible

@jorgecarleitao
Copy link
Member

Closing and reopened the JIRA one, since this operation will be done in apache/arrow

@jorgecarleitao jorgecarleitao changed the title [RUST] [CI] Remove Rust and point integration tests to arrow-rs repo Remove Rust and point integration tests to arrow-rs repo May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

No branches or pull requests

2 participants