Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust version to 1.62 #2143

Closed
Ted-Jiang opened this issue Jul 23, 2022 · 2 comments · Fixed by #2144
Closed

Update Rust version to 1.62 #2143

Ted-Jiang opened this issue Jul 23, 2022 · 2 comments · Fixed by #2144
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate

Comments

@Ted-Jiang
Copy link
Member

Ted-Jiang commented Jul 23, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
After merge #2131
Get

error[E0658]: use of unstable library feature 'total_cmp'
   --> arrow/src/compute/kernels/sort.rs:178:22
    |
178 |             |x, y| x.total_cmp(&y),
    |                      ^^^^^^^^^
    |
    = note: see issue #72599 <https://github.com/rust-lang/rust/issues/72599> for more information

https://doc.rust-lang.org/stable/std/primitive.f64.html#method.total_cmp

Do we need update rust version to 1.62 @alamb @Dandandan

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@Ted-Jiang Ted-Jiang added the enhancement Any new improvement worthy of a entry in the changelog label Jul 23, 2022
@Ted-Jiang
Copy link
Member Author

If we update it to 1.62, we should also do in datafusion right?

@Dandandan
Copy link
Contributor

Yes, total_cmp is a stable feature since 1.62, so requires at least this rust version to compile.

@alamb alamb added parquet Changes to the parquet crate arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet-derive labels Jul 26, 2022
@alamb alamb changed the title Need update version to 1.62 Update Rust version to 1.62 Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants