Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlightSqlService trait does not allow impls to do handshake #2210

Closed
avantgardnerio opened this issue Jul 28, 2022 · 0 comments · Fixed by #2211
Closed

FlightSqlService trait does not allow impls to do handshake #2210

avantgardnerio opened this issue Jul 28, 2022 · 0 comments · Fixed by #2211
Labels
arrow-flight Changes to the arrow-flight crate bug

Comments

@avantgardnerio
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Apache Arrow Ballista now supports FlightSQL, and can run simple statements like select 1;, however due to its architecture, tables need to be registered before any substantive queries can be run. Unfortunately, tables have to be registered on a context, or else the next query will have no idea that they were registered. The native Ballista protocol uses a custom field to implement this behavior, but for FlightSQL, we should use its native method. However the existing FlightSqlService trait forces this to return an unimplemented Err.

Describe the solution you'd like

It seems reasonable to me to extend the FlightSqlService trait proxying the raw method signature from the FlighService trait.

Describe alternatives you've considered

I don't know enough about Rust to envision another approach.

@avantgardnerio avantgardnerio added the enhancement Any new improvement worthy of a entry in the changelog label Jul 28, 2022
@alamb alamb added arrow-flight Changes to the arrow-flight crate bug and removed enhancement Any new improvement worthy of a entry in the changelog labels Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow-flight Changes to the arrow-flight crate bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants