Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ffi::ArrowArray::try_new is safe #2301

Closed
tustvold opened this issue Aug 3, 2022 · 0 comments · Fixed by #2303
Closed

Mark ffi::ArrowArray::try_new is safe #2301

tustvold opened this issue Aug 3, 2022 · 0 comments · Fixed by #2303
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

tustvold commented Aug 3, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

ffi::ArrowArray::try_new is marked unsafe, this is despite being called by the safe function Array::to_raw.

I initially thought this was a mistake in Array::to_raw but I think this API shouldn't actually be marked unsafe. In particular leaking memory is not unsafe, and this appears to be the only consequence from misuse.

Describe the solution you'd like

We should make ffi::ArrowArray::try_new safe

Describe alternatives you've considered

We could not do this

Additional context

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Aug 3, 2022
@alamb alamb changed the title ffi::ArrowArray::try_new is safe Mark ffi::ArrowArray::try_new is safe Aug 4, 2022
@alamb alamb added the arrow Changes to the arrow crate label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants