Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataType::Dictionary is out of spec #27

Closed
jorgecarleitao opened this issue Apr 24, 2021 · 1 comment
Closed

DataType::Dictionary is out of spec #27

jorgecarleitao opened this issue Apr 24, 2021 · 1 comment
Labels

Comments

@jorgecarleitao
Copy link
Member

Describe the bug

The schema.fbs and corresponding generated code has no concept of a Dictionary datatype.

However, we declare a DataType::Dictionary.

Additional context

As a user, I would like to be able to not have to change my DataType whenever I want to change an arrays' encoding. In the context of DataFusion, that uses DataType to declare the schema of the logical plan, this forbids optimizations at the physical level that e.g. would convert an array to a dictionary-encoded array, which is useful in any group-by or hashing operation.

@tustvold
Copy link
Contributor

tustvold commented Oct 28, 2022

table DictionaryEncoding is part of the definition of table Field, theoretically we could move the dictionary-ness onto Field. However, this would complicate downcasting, and given Field is part of Schema regardless, this wouldn't change the fact that dictionary-ness is an inherent part of an array's schema.

Feel free to re-open if I have missed something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants