Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of bound checking option #280

Closed
Dandandan opened this issue May 10, 2021 · 0 comments · Fixed by #281
Closed

Improve performance of bound checking option #280

Dandandan opened this issue May 10, 2021 · 0 comments · Fixed by #281
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@Dandandan
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Bound checking can be sped up by using .iter() and avoiding is_valid() for non-null indices

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@Dandandan Dandandan mentioned this issue May 10, 2021
Merged
@jorgecarleitao jorgecarleitao added enhancement Any new improvement worthy of a entry in the changelog arrow Changes to the arrow crate labels May 14, 2021
@jorgecarleitao jorgecarleitao mentioned this issue May 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Speed up bound checking in take Dandandan/arrow-rs
2 participants
@Dandandan @jorgecarleitao