Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl AsyncFileWriter by object_store #5766

Closed
Xuanwo opened this issue May 14, 2024 · 7 comments · Fixed by #6013
Closed

Impl AsyncFileWriter by object_store #5766

Xuanwo opened this issue May 14, 2024 · 7 comments · Fixed by #6013
Assignees
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@Xuanwo
Copy link
Member

Xuanwo commented May 14, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Follow up of #5738, add AsyncFileWriter support for object_store.

Describe the solution you'd like

I plan to add a ParquetObjectWriter like we do for ParquetObjectReader

Describe alternatives you've considered

None

Additional context

I'm willing to help implementing this.

@Xuanwo Xuanwo added the enhancement Any new improvement worthy of a entry in the changelog label May 14, 2024
@Xuanwo
Copy link
Member Author

Xuanwo commented May 14, 2024

cc @alamb @tustvold, feel free to assign this task to me if you think it's a good idea.

@alamb
Copy link
Contributor

alamb commented May 14, 2024

Was this closed in #5753 ?

@Xuanwo
Copy link
Member Author

Xuanwo commented May 15, 2024

Was this closed in #5753 ?

#5753 adds the trait for parquet, and this issue will impl trait for object_store.

@tustvold
Copy link
Contributor

tustvold commented May 27, 2024

How are you getting on with this, is there any way I can assist? It would be good for this to make the release early next week

@Xuanwo
Copy link
Member Author

Xuanwo commented May 28, 2024

How are you getting on with this, is there any way I can assist? It would be good for this to make the release early next week

Hi, apologies for the delay. So far, there are no known blockers; I'll provide updates here if any arise.

I aim to resolve this issue by the end of the week. If I'm unable to do so, feel free to take over next week.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 3, 2024

Hi @tustvold, I've reported a block issue here: #5834.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 13, 2024

Hi @tustvold, I've reported a block issue here: #5834.

#5834 has been fixed, I'm will come back to this issue now. I believe this one should be much simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants