Fix some clippy lints in parquet crate, rename LevelEncoder variants to conform to Rust standards
#1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1273 +/- ##
==========================================
- Coverage 83.02% 83.02% -0.01%
==========================================
Files 180 180
Lines 52269 52262 -7
==========================================
- Hits 43394 43388 -6
+ Misses 8875 8874 -1
Continue to review full report at Codecov.
|
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
|
@HaoYang670 this PR is marked "draft" - is it ready for review? |
|
Yes, ready for review. |
alamb
approved these changes
Feb 8, 2022
| if i % 8 == 0 { | ||
| v.push(0); | ||
| } | ||
| if data[i] { | ||
| if *item { |
There was a problem hiding this comment.
this type of change is not only more "idiomatic" I think it will also be faster (as bounds checks aren't being done on each access of data 👍 )
| @@ -50,11 +50,11 @@ pub fn max_buffer_size( | |||
| } | |||
|
|
|||
| /// Encoder for definition/repetition levels. | |||
| /// Currently only supports RLE and BIT_PACKED (dev/null) encoding, including v2. | |||
| /// Currently only supports Rle and BitPacked (dev/null) encoding, including v2. | |||
| pub enum LevelEncoder { | |||
There was a problem hiding this comment.
This is technically a breaking API change, but I think it is ok
There was a problem hiding this comment.
The encodings module is experimental and so this isn't actually a breaking change. Clippy ignores proposing breaking changes to the API (at least for this lint because the salt was strong).
| @@ -30,24 +30,13 @@ | |||
| //! | |||
| //! 3. [arrow::async_reader] for `async` reading and writing parquet | |||
| //! files to Arrow `RecordBatch`es (requires the `async` feature). | |||
| #![allow(incomplete_features)] | |||
| #![allow(dead_code)] | |||
| #![allow(non_camel_case_types)] | |||
| #
alamb
changed the title
LevelEncoder variants to conform to Rust standards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Re #1254. Partially close it
Rationale for this change
In this PR, we remove some disabled clippy lints and refactor the code, which includes:
What changes are included in this PR?
Are there any user-facing changes?
Some enums are renamed.