ARROW-12343: [Rust] Support auto-vectorization for min/max #9

Dandandan · 2021-04-19T16:05:17Z

This is a PoC to get some more SIMD instructions in Arrow without requiring the nightly compiler or producing not-portable binaries, inspired by this article shared by @jorgecarleitao :
https://www.nickwilcox.com/blog/autovec2/

This allows dispatching on CPU features, letting the compiler auto-vectorize the code without losing portability or introducing unsafe blocks. Here we use the multiversion crate to easily add more compiled versions with different cpu features.

On my machine:

min 512                 time:   [957.16 ns 958.57 ns 960.23 ns]                     
                        change: [-24.964% -24.524% -24.093%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) high mild
  1 (1.00%) high severe

max 512                 time:   [947.74 ns 949.47 ns 952.04 ns]                     
                        change: [-23.380% -22.955% -22.562%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
  2 (2.00%) high mild
  1 (1.00%) high severe

alamb · 2021-04-20T10:09:44Z

I rewrote master to remove the history of the other languages (and 50MB of history). This means this PR will need to be "rebased" against the current master.

The best way I found to do this was to find the relevant commits (via git log) and then cherry-pick them one at a time. For example (change COMMIT-SHA to whatever the commit actually is):

git reset --hard apache/master
git cherry-pick COMMIT-SHA
git push -f alamb

This PR enables tests for `ARROW_COMPUTE`, `ARROW_DATASET`, `ARROW_FILESYSTEM`, `ARROW_HDFS`, `ARROW_ORC`, and `ARROW_IPC` (default on). #7131 enabled a minimal set of tests as a starting point. I confirmed that these tests pass locally with the current master. In the current TravisCI environment, we cannot see this result due to a lot of error messages in `arrow-utility-test`. ``` $ git log | head -1 commit e2e6db2 % ctest ... Start 1: arrow-array-test 1/51 Test #1: arrow-array-test ..................... Passed 4.62 sec Start 2: arrow-buffer-test 2/51 Test #2: arrow-buffer-test .................... Passed 0.14 sec Start 3: arrow-extension-type-test 3/51 Test #3: arrow-extension-type-test ............ Passed 0.12 sec Start 4: arrow-misc-test 4/51 Test #4: arrow-misc-test ...................... Passed 0.14 sec Start 5: arrow-public-api-test 5/51 Test #5: arrow-public-api-test ................ Passed 0.12 sec Start 6: arrow-scalar-test 6/51 Test #6: arrow-scalar-test .................... Passed 0.13 sec Start 7: arrow-type-test 7/51 Test #7: arrow-type-test ...................... Passed 0.14 sec Start 8: arrow-table-test 8/51 Test #8: arrow-table-test ..................... Passed 0.13 sec Start 9: arrow-tensor-test 9/51 Test #9: arrow-tensor-test .................... Passed 0.13 sec Start 10: arrow-sparse-tensor-test 10/51 Test #10: arrow-sparse-tensor-test ............. Passed 0.16 sec Start 11: arrow-stl-test 11/51 Test #11: arrow-stl-test ....................... Passed 0.12 sec Start 12: arrow-concatenate-test 12/51 Test #12: arrow-concatenate-test ............... Passed 0.53 sec Start 13: arrow-diff-test 13/51 Test #13: arrow-diff-test ...................... Passed 1.45 sec Start 14: arrow-c-bridge-test 14/51 Test #14: arrow-c-bridge-test .................. Passed 0.18 sec Start 15: arrow-io-buffered-test 15/51 Test #15: arrow-io-buffered-test ............... Passed 0.20 sec Start 16: arrow-io-compressed-test 16/51 Test #16: arrow-io-compressed-test ............. Passed 3.48 sec Start 17: arrow-io-file-test 17/51 Test #17: arrow-io-file-test ................... Passed 0.74 sec Start 18: arrow-io-hdfs-test 18/51 Test #18: arrow-io-hdfs-test ................... Passed 0.12 sec Start 19: arrow-io-memory-test 19/51 Test #19: arrow-io-memory-test ................. Passed 2.77 sec Start 20: arrow-utility-test 20/51 Test #20: arrow-utility-test ...................***Failed 5.65 sec Start 21: arrow-threading-utility-test 21/51 Test #21: arrow-threading-utility-test ......... Passed 1.34 sec Start 22: arrow-compute-compute-test 22/51 Test #22: arrow-compute-compute-test ........... Passed 0.13 sec Start 23: arrow-compute-boolean-test 23/51 Test #23: arrow-compute-boolean-test ........... Passed 0.15 sec Start 24: arrow-compute-cast-test 24/51 Test #24: arrow-compute-cast-test .............. Passed 0.22 sec Start 25: arrow-compute-hash-test 25/51 Test #25: arrow-compute-hash-test .............. Passed 2.61 sec Start 26: arrow-compute-isin-test 26/51 Test #26: arrow-compute-isin-test .............. Passed 0.81 sec Start 27: arrow-compute-match-test 27/51 Test #27: arrow-compute-match-test ............. Passed 0.40 sec Start 28: arrow-compute-sort-to-indices-test 28/51 Test #28: arrow-compute-sort-to-indices-test ... Passed 3.33 sec Start 29: arrow-compute-nth-to-indices-test 29/51 Test #29: arrow-compute-nth-to-indices-test .... Passed 1.51 sec Start 30: arrow-compute-util-internal-test 30/51 Test #30: arrow-compute-util-internal-test ..... Passed 0.13 sec Start 31: arrow-compute-add-test 31/51 Test #31: arrow-compute-add-test ............... Passed 0.12 sec Start 32: arrow-compute-aggregate-test 32/51 Test #32: arrow-compute-aggregate-test ......... Passed 14.70 sec Start 33: arrow-compute-compare-test 33/51 Test #33: arrow-compute-compare-test ........... Passed 7.96 sec Start 34: arrow-compute-take-test 34/51 Test #34: arrow-compute-take-test .............. Passed 4.80 sec Start 35: arrow-compute-filter-test 35/51 Test #35: arrow-compute-filter-test ............ Passed 8.23 sec Start 36: arrow-dataset-dataset-test 36/51 Test #36: arrow-dataset-dataset-test ........... Passed 0.25 sec Start 37: arrow-dataset-discovery-test 37/51 Test #37: arrow-dataset-discovery-test ......... Passed 0.13 sec Start 38: arrow-dataset-file-ipc-test 38/51 Test #38: arrow-dataset-file-ipc-test .......... Passed 0.21 sec Start 39: arrow-dataset-file-test 39/51 Test #39: arrow-dataset-file-test .............. Passed 0.12 sec Start 40: arrow-dataset-filter-test 40/51 Test #40: arrow-dataset-filter-test ............ Passed 0.16 sec Start 41: arrow-dataset-partition-test 41/51 Test #41: arrow-dataset-partition-test ......... Passed 0.13 sec Start 42: arrow-dataset-scanner-test 42/51 Test #42: arrow-dataset-scanner-test ........... Passed 0.20 sec Start 43: arrow-filesystem-test 43/51 Test #43: arrow-filesystem-test ................ Passed 1.62 sec Start 44: arrow-hdfs-test 44/51 Test #44: arrow-hdfs-test ...................... Passed 0.13 sec Start 45: arrow-feather-test 45/51 Test #45: arrow-feather-test ................... Passed 0.91 sec Start 46: arrow-ipc-read-write-test 46/51 Test #46: arrow-ipc-read-write-test ............ Passed 5.77 sec Start 47: arrow-ipc-json-simple-test 47/51 Test #47: arrow-ipc-json-simple-test ........... Passed 0.16 sec Start 48: arrow-ipc-json-test 48/51 Test #48: arrow-ipc-json-test .................. Passed 0.27 sec Start 49: arrow-json-integration-test 49/51 Test #49: arrow-json-integration-test .......... Passed 0.13 sec Start 50: arrow-json-test 50/51 Test #50: arrow-json-test ...................... Passed 0.26 sec Start 51: arrow-orc-adapter-test 51/51 Test #51: arrow-orc-adapter-test ............... Passed 1.92 sec 98% tests passed, 1 tests failed out of 51 Label Time Summary: arrow-tests = 27.38 sec (27 tests) arrow_compute = 45.11 sec (14 tests) arrow_dataset = 1.21 sec (7 tests) arrow_ipc = 6.20 sec (3 tests) unittest = 79.91 sec (51 tests) Total Test time (real) = 79.99 sec The following tests FAILED: 20 - arrow-utility-test (Failed) Errors while running CTest ``` Closes #7142 from kiszk/ARROW-8754 Authored-by: Kazuaki Ishizaki <ishizaki@jp.ibm.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>

alamb · 2021-04-20T11:08:22Z

@Dandandan I would be happy to rebase this PR for you -- just let me know

Dandandan · 2021-04-20T17:57:06Z

This PR is updated

codecov-commenter · 2021-04-20T18:13:41Z

Codecov Report

Merging #9 (3f39291) into master (861b572) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   82.49%   82.48%   -0.01%     
==========================================
  Files         162      162              
  Lines       43521    43522       +1     
==========================================
  Hits        35901    35901              
- Misses       7620     7621       +1

Impacted Files	Coverage Δ
arrow/src/compute/kernels/aggregate.rs	`73.40% <100.00%> (+0.07%)`	⬆️
parquet/src/encodings/encoding.rs	`94.86% <0.00%> (-0.20%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 861b572...3f39291. Read the comment docs.

jorgecarleitao · 2021-04-21T15:57:34Z

We had to perform a small re-write of master. The commits may look a bit odd, but it should not cause conflicts. Could you kindly rebase this against the latest master to make it easier to review?

Dandandan · 2021-04-21T17:13:20Z

@jorgecarleitao fixed

jorgecarleitao · 2021-04-21T18:27:20Z

The check build is failing for some reason. Any idea why? Maybe a bump of the stable rust?

Dandandan · 2021-04-21T19:17:09Z

Not sure... Maybe a recent upgrade to the crate that has a compile error?

Dandandan · 2021-04-23T07:22:25Z

@jorgecarleitao al green now

jorgecarleitao

LGTM! Super cool

tustvold · 2023-01-04T14:03:58Z

FYI this is being reverted in #3452 as it is causing pain, and doesn't have a well defined maintenance story. The recommendation continues to be that people compile with the relevant features enabled

Dandandan mentioned this pull request Apr 19, 2021

ARROW-12343: [Rust] Support auto-vectorization for min/max apache/arrow#10002

Closed

jorgecarleitao added the arrow Changes to the arrow crate label Apr 19, 2021

alamb force-pushed the master branch from ae812db to 7f60f0b Compare April 20, 2021 10:00

alamb force-pushed the master branch from 7f60f0b to 5b3298a Compare April 20, 2021 10:14

Dandandan closed this Apr 20, 2021

Dandandan force-pushed the auto_vec branch from 9007547 to 5479e19 Compare April 20, 2021 13:48

Dandandan reopened this Apr 20, 2021

jorgecarleitao force-pushed the master branch from 5479e19 to 3d7cefb Compare April 21, 2021 13:54

Support auto-vectorization for min/max using multiversion

ac34adb

Dandandan force-pushed the auto_vec branch from 3fbdd03 to ac34adb Compare April 21, 2021 17:13

jorgecarleitao approved these changes Apr 21, 2021

View reviewed changes

Merge remote-tracking branch 'upstream/master' into auto_vec

3f39291

jorgecarleitao approved these changes Apr 23, 2021

View reviewed changes

jorgecarleitao merged commit 463f88f into apache:master Apr 23, 2021

alamb mentioned this pull request Apr 26, 2021

Support auto-vectorization for min/max #209

Closed

jorgecarleitao mentioned this pull request May 14, 2021

Added changelog generator script and configuration. #289

Merged

alamb added the enhancement Any new improvement worthy of a entry in the changelog label Jul 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARROW-12343: [Rust] Support auto-vectorization for min/max #9

ARROW-12343: [Rust] Support auto-vectorization for min/max #9

Dandandan commented Apr 19, 2021

alamb commented Apr 20, 2021

alamb commented Apr 20, 2021

Dandandan commented Apr 20, 2021

codecov-commenter commented Apr 20, 2021 •

edited

jorgecarleitao commented Apr 21, 2021

Dandandan commented Apr 21, 2021

jorgecarleitao commented Apr 21, 2021

Dandandan commented Apr 21, 2021

Dandandan commented Apr 23, 2021

jorgecarleitao left a comment

tustvold commented Jan 4, 2023 •

edited

ARROW-12343: [Rust] Support auto-vectorization for min/max #9

ARROW-12343: [Rust] Support auto-vectorization for min/max #9

Conversation

Dandandan commented Apr 19, 2021

alamb commented Apr 20, 2021

alamb commented Apr 20, 2021

Dandandan commented Apr 20, 2021

codecov-commenter commented Apr 20, 2021 • edited

Codecov Report

jorgecarleitao commented Apr 21, 2021

Dandandan commented Apr 21, 2021

jorgecarleitao commented Apr 21, 2021

Dandandan commented Apr 21, 2021

Dandandan commented Apr 23, 2021

jorgecarleitao left a comment

Choose a reason for hiding this comment

tustvold commented Jan 4, 2023 • edited

codecov-commenter commented Apr 20, 2021 •

edited

tustvold commented Jan 4, 2023 •

edited