ARROW-12493: Add support for writing dictionary arrays to CSV and JSON #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
+ Coverage 82.47% 82.48% +0.01%
==========================================
Files 162 162
Lines 43414 43447 +33
==========================================
+ Hits 35806 35838 +32
- Misses 7608 7609 +1
Continue to review full report at Codecov.
|
alamb
approved these changes
Apr 21, 2021
|
|
||
| assert_eq!( | ||
| String::from_utf8(buf).unwrap(), | ||
| r#"{"c1":"cupcakes","c2":"sdsd"} |
|
We had to perform a small re-write of master. The commits may look a bit odd, but it should not cause conflicts. Could you kindly rebase this against the latest master to make it easier to review? |
tustvold
force-pushed
the
dictionary-format
branch
from
4fa2a1c
to
7f425c7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide support for serializing dictionary arrays to CSV and JSON by hydrating them to their underlying representation. This is not the most efficient way to do this, but was the simplest way I could think of to cover all bases.
It may be worthwhile special-casing StringDictionaries with a more efficient implementation in a subsequent PR, as I imagine they're the most common form of DictionaryArray.