Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Remove dependency on RangeEqualsVisitor from ValueVector interface #22600

Closed
asfimport opened this issue Aug 12, 2019 · 6 comments
Closed

Comments

@asfimport
Copy link
Collaborator

asfimport commented Aug 12, 2019

This is a follow-up from #4933

 

public interface VectorVisitor<OUT, IN, EX extends Exception> {..}

 

In ValueVector : 

public <OUT, IN, EX extends Exception> OUT accept(VectorVisitor<OUT, IN, EX> visitor, IN value) throws EX;

 

Reporter: Pindikura Ravindra / @pravindra
Assignee: Ji Liu / @tianchen92

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-6211. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Bryan Cutler / @BryanCutler:
So will this allow for other types of visitors besides a RangeEqualsVisitor?

@asfimport
Copy link
Collaborator Author

Pindikura Ravindra / @pravindra:
yes, I think it should.

@asfimport
Copy link
Collaborator Author

Ji Liu / @tianchen92:
@pravindra  One more question, 'IN value' above is unnecessary?

@asfimport
Copy link
Collaborator Author

Pindikura Ravindra / @pravindra:
It'll be useful for generic visitors to carry state (the IN value allows that). For the RangeEqualsVisitors, you can always use Void.

@asfimport
Copy link
Collaborator Author

Bryan Cutler / @BryanCutler:
This sounds good to me then, I agree it would be useful to have a generic visitor api

@asfimport
Copy link
Collaborator Author

Pindikura Ravindra / @pravindra:
Issue resolved by pull request 5091
#5091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants