Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] warnings building on mingw-w64 #23359

Closed
asfimport opened this issue Nov 2, 2019 · 5 comments
Closed

[C++] warnings building on mingw-w64 #23359

asfimport opened this issue Nov 2, 2019 · 5 comments
Assignees
Milestone

Comments

@asfimport
Copy link
Collaborator

Two warnings when building libarrow 0.15.1 on mingw-w64:

[  2%] Running thrift compiler on parquet.thrift
[WARNING:C:/msys64/home/mingw-packages/mingw-w64-arrow/src/apache-arrow-0.15.1/cpp/src/parquet/parquet.thrift:297] The "byte" type is a compatibility alias for "i8". Use "i8" to emphasize the signedness of this type.

And later:

 81%] Building CXX object src/parquet/CMakeFiles/parquet_static.dir/column_reader.cc.obj
C:/msys64/home/mingw-packages/mingw-w64-arrow/src/apache-arrow-0.15.1/cpp/src/parquet/arrow/writer.cc: In member function 'virtual arrow::Status parquet::arrow::FileWriterImpl::WriteColumnChunk(const std::shared_ptr<arrow::ChunkedArray>&, int64_t, int64_t)':
C:/msys64/home/mingw-packages/mingw-w64-arrow/src/apache-arrow-0.15.1/cpp/src/parquet/arrow/writer.cc:79:41: warning: 'schema_field' may be used uninitialized in this function [-Wmaybe-uninitialized]
         schema_manifest_(schema_manifest) {}
                                         ^
C:/msys64/home/mingw-packages/mingw-w64-arrow/src/apache-arrow-0.15.1/cpp/src/parquet/arrow/writer.cc:466:24: note: 'schema_field' was declared here
     const SchemaField* schema_field;

Maybe CI with CXXFLAGS += -Werror ?

Reporter: Jeroen / @jeroen
Assignee: Ben Kietzman / @bkietz

PRs and other links:

Note: This issue was originally created as ARROW-7049. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
@jeroen Do you want to provide a PR for this?

@asfimport
Copy link
Collaborator Author

Francois Saint-Jacques / @fsaintjacques:
These warnings are fixed on master. @mrkn can you confirm that there is no other warnings?

@asfimport
Copy link
Collaborator Author

Neal Richardson / @nealrichardson:
There are a few others now, see the build log at https://github.com/apache/arrow/runs/527579208?check_suite_focus=true#step:7:1096 for example

@asfimport
Copy link
Collaborator Author

Ben Kietzman / @bkietz:
Some of those warnings are spurious and arise from generated code, so -Werror isn't viable here. The warnings regarding FieldRef are semi legitimate, I'll open a PR to fix them

@asfimport
Copy link
Collaborator Author

Ben Kietzman / @bkietz:
Issue resolved by pull request 6691
#6691

@asfimport asfimport added this to the 0.17.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants