Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][CSV] Add support for ReadOptions::skip_rows >= block_size #24696

Closed
asfimport opened this issue Apr 20, 2020 · 2 comments
Closed

[C++][CSV] Add support for ReadOptions::skip_rows >= block_size #24696

asfimport opened this issue Apr 20, 2020 · 2 comments

Comments

@asfimport
Copy link
Collaborator

asfimport commented Apr 20, 2020

Current implementation throws error in reader.cc:286 when skip_rows > header. However, in some workloads skip_rows used for not only skipping header but for just skipping first n-rows. In this case block-size constraint is greatly interferes. I think this constraint could be removed without performance reduction.

Reporter: Ravil Bikbulatov
Assignee: Nate Clark / @n3world

Related issues:

Note: This issue was originally created as ARROW-8527. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Weston Pace / @westonpace:
This behavior could be useful for ARROW-12598.  Also, in a recent discussion, n3world (no Jira I can find) pointed out that skip_rows is probably not the best tool for this.  This sort of "paging" would require skipping data rows so it would be nice if the "skip header rows" (constant parameter based on the tool generating the data) is distinct from "skip data rows" (per query parameter based on paging needs)

@asfimport
Copy link
Collaborator Author

Nate Clark / @n3world:
Resolved with the solution for ARROW-12661. skip_rows_after_names can skip rows in multiple blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant