Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R][CI] Add check that all docs pages are listed in _pkgdown.yml #28051

Closed
asfimport opened this issue Apr 6, 2021 · 1 comment
Closed

[R][CI] Add check that all docs pages are listed in _pkgdown.yml #28051

asfimport opened this issue Apr 6, 2021 · 1 comment

Comments

@asfimport
Copy link
Collaborator

Our (external) nightly R packaging and docs build is failing to render the pkgdown site: https://github.com/ursa-labs/arrow-r-nightly/runs/2266551062?check_suite_focus=true#step:9:55

This is due to (1) a new-ish change in pkgdown that errors if topics are not included and (2) the recent addition of FragmentScanOptions, which did not get added to _pkgdown.yml.

We should validate this on our regular CI in order to prevent future issues like this. We often have to add things to _pkgdown.yml right at release time, and it would be better to keep up as we go. Some ideas for how:

  • Add a step to an existing R workflow (e.g. https://github.com/apache/arrow/blob/master/.github/workflows/r.yml#L60) that does this check
  • Add a new workflow that is triggered only on changes to r/man and r/_pkgdown.yml
  • In either case, this could be done as a bash script, a python script, or an R script. If using R, note that the docker-based CI jobs won't have R installed, so you might want to tack it onto one of the windows jobs (which uses the setup-r action), but then you're in windows.
  • You could install pkgdown and try to build the site, but that's a lot of dependency to download and install just to essentially compare some lines in a yaml file with a directory listing (i.e., make sure that all r/man/*.Rd have corresponding entries in the reference part of the yml), so python or even a bash script might be more efficient to run. And since this is going to run a lot, it's worth considering how to keep runtime down even if that means more work to set it up.
  • If you're scripting this standalone, think you'll need to filter out Rd files that have \keyword{internal} as pkgdown excludes those from the reference list.

Reporter: Neal Richardson / @nealrichardson
Assignee: Nicola Crane / @thisisnic

PRs and other links:

Note: This issue was originally created as ARROW-12236. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Neal Richardson / @nealrichardson:
Issue resolved by pull request 9946
#9946

@asfimport asfimport added this to the 4.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants