Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] expect_dplyr_equal() test helper function ignores grouping #29617

Closed
asfimport opened this issue Sep 16, 2021 · 1 comment
Closed

[R] expect_dplyr_equal() test helper function ignores grouping #29617

asfimport opened this issue Sep 16, 2021 · 1 comment

Comments

@asfimport
Copy link
Collaborator

I'm writing bindings for dplyr::distinct() and I have a unit test which uses expect_dplyr_equal() and passes despite the result incorrectly dropping groups.

See:
https://github.com/apache/arrow/pull/11143/files#diff-aea5ce6c4634423c094e06eaa84000ad9b92f7ed5127f1678dc51892c54003ceR56-R63

Reporter: Nicola Crane / @thisisnic
Assignee: Neal Richardson / @nealrichardson

Note: This issue was originally created as ARROW-14019. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Neal Richardson / @nealrichardson:
It's because it is using expect_equivalent, which ignores attributes. I'll deal with this in ARROW-13550 (I have to in order to test that feature).

@asfimport asfimport added this to the 6.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants