Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] CSV test_cancellation unittests fail on Apple M1 #30001

Closed
asfimport opened this issue Oct 22, 2021 · 8 comments
Closed

[Python] CSV test_cancellation unittests fail on Apple M1 #30001

asfimport opened this issue Oct 22, 2021 · 8 comments

Comments

@asfimport
Copy link
Collaborator

Perhaps M1 is too quick :)

Most noticable when running the release verification tasks: #11511

Failing builds:

Reporter: Krisztian Szucs / @kszucs
Assignee: Antoine Pitrou / @pitrou

PRs and other links:

Note: This issue was originally created as ARROW-14437. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

@asfimport
Copy link
Collaborator Author

Joris Van den Bossche / @jorisvandenbossche:
cc @AlenkaF since you have an M1, it would be interesting to see if you can reproduce this (and if so, if it is solved by reducing the sleep time)

@asfimport
Copy link
Collaborator Author

Alenka Frim / @AlenkaF:
@jorisvandenbossche  that would be interesting. We'll do it together as M1 truly is too fast for me :D

@asfimport
Copy link
Collaborator Author

Yibo Cai / @cyb70289:
Remember I once met with this issue.
https://issues.apache.org/jira/browse/ARROW-12241
Looks we should make the workload even larger?
#9920

@asfimport
Copy link
Collaborator Author

Alenka Frim / @AlenkaF:
The csv test passes on my M1 in debug or release mode.

@asfimport
Copy link
Collaborator Author

Yibo Cai / @cyb70289:
I cannot reproduce the error locally either, even after increase the sleep time [1] to 1s.
1.5s does fails the test. I tested on 8 core M1, 16G ram, with AC power connected, release build.

[1] https://github.com/apache/arrow/blob/master/python/pyarrow/tests/test_csv.py#L1328

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
Perhaps the solution is to dynamically size the workload.

@asfimport
Copy link
Collaborator Author

Krisztian Szucs / @kszucs:
Issue resolved by pull request 11598
#11598

@asfimport asfimport added this to the 6.0.1 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants