-
Notifications
You must be signed in to change notification settings - Fork 3.5k
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dev] PR Workflow incorrectly tagging committer reviews that have their Apache membership set to private #34381
Comments
That is not exactly true. It seems to happen only for some committers. Maybe there's something wrong on the GitHub permissions? |
As pointed out by @assignUser this might have to do with some users setting their Apache role to private (https://github.com/orgs/apache/people) similar to: flutter/flutter#101012 |
I have tested giving all possible read permissions to the workflow and requesting via API instead of using the default payload event using the
This would work but would require to set up a new secret on our repo, something like |
We already have a commiter list: https://github.com/apache/arrow-site/blob/main/_data/committers.yml |
Oh nice, as the list already exists and is even in yaml it should be easy to use! |
Thanks @kou I forgot this existed. Yes that should work. I'll take the committer GitHub usernames from there. |
…yml instead of relying on author_association
…stead of relying on author_association (#34557) ### Rationale for this change If a committer has their ASF role on GitHub as private the GitHub PR bot author_association is not correctly assigned. ### What changes are included in this PR? This change uses the committers list on the arrow_site repository to retrieve the list of committers. ### Are these changes tested? There is a unit test and have tested the different steps of the workflow individually but haven't tested the full workflow. ### Are there any user-facing changes? No * Closes: #34381 Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…yml instead of relying on author_association (apache#34557) ### Rationale for this change If a committer has their ASF role on GitHub as private the GitHub PR bot author_association is not correctly assigned. ### What changes are included in this PR? This change uses the committers list on the arrow_site repository to retrieve the list of committers. ### Are these changes tested? There is a unit test and have tested the different steps of the workflow individually but haven't tested the full workflow. ### Are there any user-facing changes? No * Closes: apache#34381 Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Describe the bug, including details regarding any error messages, version, and platform.
Committer GitHub role is CONTRIBUTOR instead of MEMBER.
Example of event payload for event triggered from Committer:
Component(s)
Developer Tools
The text was updated successfully, but these errors were encountered: