Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-34381: [Dev] Retrieve committers from arrow-site committers.yml instead of relying on author_association #34557

Merged
merged 4 commits into from
Mar 15, 2023
Merged

GH-34381: [Dev] Retrieve committers from arrow-site committers.yml instead of relying on author_association #34557

merged 4 commits into from
Mar 15, 2023

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Mar 14, 2023 •
edited by github-actions bot
Loading

Rationale for this change

If a committer has their ASF role on GitHub as private the GitHub PR bot author_association is not correctly assigned.

What changes are included in this PR?

This change uses the committers list on the arrow_site repository to retrieve the list of committers.

Are these changes tested?

There is a unit test and have tested the different steps of the workflow individually but haven't tested the full workflow.

Are there any user-facing changes?

No

@raulcd
apacheGH-34381: [Dev] Retrieve committers from arrow-site committers.…
add2e1a 
…yml instead of relying on author_association
@github-actions
Copy link

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Mar 14, 2023
raulcd
raulcd commented Mar 14, 2023
View reviewed changes
Copy link
Member Author

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test trigger workflow change

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Mar 14, 2023
@raulcd raulcd added awaiting review Awaiting review awaiting committer review Awaiting committer review and removed awaiting changes Awaiting changes awaiting review Awaiting review labels Mar 14, 2023
kou
kou reviewed Mar 14, 2023
View reviewed changes
.github/workflows/pr_bot.yml Outdated Show resolved Hide resolved
.github/workflows/pr_bot.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Mar 14, 2023
@raulcd @kou
Apply suggestions from code review
a249774 
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actions github-actions bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Mar 14, 2023
@raulcd raulcd added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Mar 14, 2023
assignUser
assignUser approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kou
Copy link
Member

kou commented Mar 15, 2023

How to confirm whether the change works or not?
Should we merge this into the main for it?

@raulcd
Copy link
Member Author

raulcd commented Mar 15, 2023

How to confirm whether the change works or not? Should we merge this into the main for it?

I have confirmed the change works on a similar scenario:
I've created an arrow-copy-repo on an organisation. I have created a fork for my user which has a private association with the org and created a PR. The user (raulcd) even though has a private association is now treated as committer, because I am part of the committer list.
Example here: te-chie-la/arrow-pr-workflow-copy#36
As you can see I had to tweak based on the tests as there was something wrong on reading the file but now it has been fully tested.

kou
kou approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit fe88d9a into apache:main Mar 15, 2023
@github-actions github-actions bot removed the awaiting change review Awaiting change review label Mar 15, 2023
@github-actions github-actions bot added the awaiting merge Awaiting merge label Mar 15, 2023
@ursabot
Copy link

ursabot commented Mar 16, 2023

Benchmark runs are scheduled for baseline = 6ba2255 and contender = fe88d9a. fe88d9a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.39% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.51% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.22% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] fe88d9ad ec2-t3-xlarge-us-east-2
[Finished] fe88d9ad test-mac-arm
[Finished] fe88d9ad ursa-i9-9960x
[Finished] fe88d9ad ursa-thinkcentre-m75q
[Finished] 6ba2255c ec2-t3-xlarge-us-east-2
[Finished] 6ba2255c test-mac-arm
[Finished] 6ba2255c ursa-i9-9960x
[Finished] 6ba2255c ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Mar 16, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

This was referenced Mar 23, 2023
Open
Open
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request Mar 27, 2023
@raulcd @kou @rtpsw
apacheGH-34381: [Dev] Retrieve committers from arrow-site committers.…
affb186 
…yml instead of relying on author_association (apache#34557)

### Rationale for this change

If a committer has their ASF role on GitHub as private the GitHub PR bot author_association is not correctly assigned.

### What changes are included in this PR?

 This change uses the committers list on the arrow_site repository to retrieve the list of committers.

### Are these changes tested?

There is a unit test and have tested the different steps of the workflow individually but haven't tested the full workflow.

### Are there any user-facing changes?

No
* Closes: apache#34381

Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@raulcd raulcd mentioned this pull request Apr 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assignUser assignUser assignUser approved these changes

@kou kou kou approved these changes

Assignees
No one assigned
Labels
awaiting merge Awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dev] PR Workflow incorrectly tagging committer reviews that have their Apache membership set to private
4 participants
@raulcd @kou @ursabot @assignUser