-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] Expose Location.toSocketAddress #34692
Labels
Milestone
Comments
lidavidm
pushed a commit
that referenced
this issue
Mar 22, 2023
### Rationale for this change ### What changes are included in this PR? Change `Location.toSocketAddress()` to a public method. This is useful for creating a `FlightClient` via `FlightGrpcUtils.createFlightClient`: https://github.com/apache/arrow/blob/08fb86107b001e2e1903ae0e416ff51386d4239e/java/flight/flight-grpc/src/main/java/org/apache/arrow/flight/FlightGrpcUtils.java#L148 ### Are these changes tested? ### Are there any user-facing changes? * Closes: #34692 Authored-by: Jie Zhang <zhangjie@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this issue
Mar 27, 2023
### Rationale for this change ### What changes are included in this PR? Change `Location.toSocketAddress()` to a public method. This is useful for creating a `FlightClient` via `FlightGrpcUtils.createFlightClient`: https://github.com/apache/arrow/blob/08fb86107b001e2e1903ae0e416ff51386d4239e/java/flight/flight-grpc/src/main/java/org/apache/arrow/flight/FlightGrpcUtils.java#L148 ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#34692 Authored-by: Jie Zhang <zhangjie@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this issue
May 15, 2023
### Rationale for this change ### What changes are included in this PR? Change `Location.toSocketAddress()` to a public method. This is useful for creating a `FlightClient` via `FlightGrpcUtils.createFlightClient`: https://github.com/apache/arrow/blob/08fb86107b001e2e1903ae0e416ff51386d4239e/java/flight/flight-grpc/src/main/java/org/apache/arrow/flight/FlightGrpcUtils.java#L148 ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#34692 Authored-by: Jie Zhang <zhangjie@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
This is useful for people using gRPC directly and Flight
Component(s)
Java
The text was updated successfully, but these errors were encountered: