Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Expose Location.toSocketAddress #34692

Closed
lidavidm opened this issue Mar 22, 2023 · 0 comments · Fixed by #34648
Closed

[Java] Expose Location.toSocketAddress #34692

lidavidm opened this issue Mar 22, 2023 · 0 comments · Fixed by #34648
Labels
Component: Java Type: enhancement
Milestone
12.0.0

Comments

@lidavidm
Copy link
Member

Describe the enhancement requested

This is useful for people using gRPC directly and Flight

Component(s)

Java
@github-actions github-actions bot mentioned this issue Mar 22, 2023
Merged
lidavidm pushed a commit that referenced this issue Mar 22, 2023
@jiezhang
GH-34692: [Java] Expose Location.toSocketAddress (#34648)
fd5d710 
### Rationale for this change

### What changes are included in this PR?

Change `Location.toSocketAddress()` to a public method. This is useful for creating a `FlightClient` via `FlightGrpcUtils.createFlightClient`:

https://github.com/apache/arrow/blob/08fb86107b001e2e1903ae0e416ff51386d4239e/java/flight/flight-grpc/src/main/java/org/apache/arrow/flight/FlightGrpcUtils.java#L148

### Are these changes tested?

### Are there any user-facing changes?

* Closes: #34692

Authored-by: Jie Zhang <zhangjie@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 12.0.0 milestone Mar 22, 2023
rtpsw pushed a commit to rtpsw/arrow that referenced this issue Mar 27, 2023
@jiezhang @rtpsw
apacheGH-34692: [Java] Expose Location.toSocketAddress (apache#34648)
6af38ba 
### Rationale for this change

### What changes are included in this PR?

Change `Location.toSocketAddress()` to a public method. This is useful for creating a `FlightClient` via `FlightGrpcUtils.createFlightClient`:

https://github.com/apache/arrow/blob/08fb86107b001e2e1903ae0e416ff51386d4239e/java/flight/flight-grpc/src/main/java/org/apache/arrow/flight/FlightGrpcUtils.java#L148

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#34692

Authored-by: Jie Zhang <zhangjie@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@jiezhang @ArgusLi
apacheGH-34692: [Java] Expose Location.toSocketAddress (apache#34648)
c10944e 
### Rationale for this change

### What changes are included in this PR?

Change `Location.toSocketAddress()` to a public method. This is useful for creating a `FlightClient` via `FlightGrpcUtils.createFlightClient`:

https://github.com/apache/arrow/blob/08fb86107b001e2e1903ae0e416ff51386d4239e/java/flight/flight-grpc/src/main/java/org/apache/arrow/flight/FlightGrpcUtils.java#L148

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#34692

Authored-by: Jie Zhang <zhangjie@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Java Type: enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34692: [Java] Expose Location.toSocketAddress jiezhang/arrow
1 participant
@lidavidm