Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-34692: [Java] Expose Location.toSocketAddress #34648

Merged
merged 3 commits into from
Mar 22, 2023
Merged

GH-34692: [Java] Expose Location.toSocketAddress #34648

merged 3 commits into from
Mar 22, 2023

Conversation

jiezhang
Copy link
Contributor

@jiezhang jiezhang commented Mar 20, 2023 •
edited by github-actions bot
Loading

Rationale for this change

What changes are included in this PR?

Change Location.toSocketAddress() to a public method. This is useful for creating a FlightClient via FlightGrpcUtils.createFlightClient:

arrow/java/flight/flight-grpc/src/main/java/org/apache/arrow/flight/FlightGrpcUtils.java

Line 148 in 08fb861

public static FlightClient createFlightClient(BufferAllocator incomingAllocator, ManagedChannel channel) {

Are these changes tested?

Are there any user-facing changes?

@jiezhang jiezhang requested a review from lidavidm as a code owner March 20, 2023 21:39
@jiezhang jiezhang mentioned this pull request Mar 20, 2023
Closed
@lidavidm
Copy link
Member

Thanks!

Would it be possible to add a simple test with one or two asserts, just for sanity checking? I see it's only indirectly tested so far, but now that it's a public API it deserves a little testing

@jiezhang
Copy link
Contributor Author

Looks like there is a flaky test: TestBasicOperation.getStreamLargeBatch

https://github.com/apache/arrow/actions/runs/4484616893/jobs/7885328198

lidavidm
lidavidm approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lidavidm
Copy link
Member

Looks like there is a flaky test: TestBasicOperation.getStreamLargeBatch

https://github.com/apache/arrow/actions/runs/4484616893/jobs/7885328198

#33238

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Mar 22, 2023
@lidavidm lidavidm changed the title MINOR: [Java] Expose Location.toSocketAddress GH-34692: [Java] Expose Location.toSocketAddress Mar 22, 2023
@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #34692 has been automatically assigned in GitHub to PR creator.

@lidavidm
Copy link
Member

I filed an issue for this (don't think it's technically minor); you can comment 'take' on the issue to have it assigned to you

@lidavidm lidavidm merged commit fd5d710 into apache:main Mar 22, 2023
@jiezhang jiezhang deleted the location branch March 22, 2023 20:59
@ursabot
Copy link

ursabot commented Mar 23, 2023

Benchmark runs are scheduled for baseline = d526fd9 and contender = fd5d710. fd5d710 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.03% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.26% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.22% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] fd5d7107 ec2-t3-xlarge-us-east-2
[Failed] fd5d7107 test-mac-arm
[Finished] fd5d7107 ursa-i9-9960x
[Finished] fd5d7107 ursa-thinkcentre-m75q
[Finished] d526fd9d ec2-t3-xlarge-us-east-2
[Finished] d526fd9d test-mac-arm
[Finished] d526fd9d ursa-i9-9960x
[Finished] d526fd9d ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

rtpsw pushed a commit to rtpsw/arrow that referenced this pull request Mar 27, 2023
@jiezhang @rtpsw
apacheGH-34692: [Java] Expose Location.toSocketAddress (apache#34648)
6af38ba 
### Rationale for this change

### What changes are included in this PR?

Change `Location.toSocketAddress()` to a public method. This is useful for creating a `FlightClient` via `FlightGrpcUtils.createFlightClient`:

https://github.com/apache/arrow/blob/08fb86107b001e2e1903ae0e416ff51386d4239e/java/flight/flight-grpc/src/main/java/org/apache/arrow/flight/FlightGrpcUtils.java#L148

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#34692

Authored-by: Jie Zhang <zhangjie@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@jiezhang @ArgusLi
apacheGH-34692: [Java] Expose Location.toSocketAddress (apache#34648)
c10944e 
### Rationale for this change

### What changes are included in this PR?

Change `Location.toSocketAddress()` to a public method. This is useful for creating a `FlightClient` via `FlightGrpcUtils.createFlightClient`:

https://github.com/apache/arrow/blob/08fb86107b001e2e1903ae0e416ff51386d4239e/java/flight/flight-grpc/src/main/java/org/apache/arrow/flight/FlightGrpcUtils.java#L148

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#34692

Authored-by: Jie Zhang <zhangjie@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Java] Expose Location.toSocketAddress
3 participants
@jiezhang @lidavidm @ursabot