Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] RecordBatch support EqualOptions in Equals and ApproxEquals #34968

Closed
mapleFU opened this issue Apr 7, 2023 · 0 comments · Fixed by #34970
Closed

[C++] RecordBatch support EqualOptions in Equals and ApproxEquals #34968

mapleFU opened this issue Apr 7, 2023 · 0 comments · Fixed by #34970
Assignees
@mapleFU
Labels
Component: C++ Type: enhancement
Milestone
12.0.0

Comments

@mapleFU
Copy link
Member

mapleFU commented Apr 7, 2023

Describe the enhancement requested

Currently, directly comparing Array supports EqualOptions, which support nan comparing mode and others. However, array doesn't support passing argument like that. So, it can only use default EqualOptions

Component(s)

C++
@github-actions github-actions bot mentioned this issue Apr 7, 2023
Merged
@westonpace westonpace added this to the 12.0.0 milestone Apr 11, 2023
westonpace pushed a commit that referenced this issue Apr 11, 2023
@mapleFU
GH-34968: [C++] Add Equal Options to RecordBatch (#34970)
1aedf52 
### Rationale for this change

Currently, directly comparing Array supports EqualOptions, which support nan comparing mode and others. However, array doesn't support passing argument like that. So, it can only use default EqualOptions

### What changes are included in this PR?

Add EqualOptions 

### Are these changes tested?

currently not

### Are there any user-facing changes?

User can call EqualOptions in RecordBatch

* Closes: #34968

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@mapleFU @liujiacheng777
apacheGH-34968: [C++] Add Equal Options to RecordBatch (apache#34970)
2c1c08b 
### Rationale for this change

Currently, directly comparing Array supports EqualOptions, which support nan comparing mode and others. However, array doesn't support passing argument like that. So, it can only use default EqualOptions

### What changes are included in this PR?

Add EqualOptions 

### Are these changes tested?

currently not

### Are there any user-facing changes?

User can call EqualOptions in RecordBatch

* Closes: apache#34968

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@mapleFU @ArgusLi
apacheGH-34968: [C++] Add Equal Options to RecordBatch (apache#34970)
95e97a4 
### Rationale for this change

Currently, directly comparing Array supports EqualOptions, which support nan comparing mode and others. However, array doesn't support passing argument like that. So, it can only use default EqualOptions

### What changes are included in this PR?

Add EqualOptions 

### Are these changes tested?

currently not

### Are there any user-facing changes?

User can call EqualOptions in RecordBatch

* Closes: apache#34968

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@mapleFU @rtpsw
apacheGH-34968: [C++] Add Equal Options to RecordBatch (apache#34970)
b157d69 
### Rationale for this change

Currently, directly comparing Array supports EqualOptions, which support nan comparing mode and others. However, array doesn't support passing argument like that. So, it can only use default EqualOptions

### What changes are included in this PR?

Add EqualOptions 

### Are these changes tested?

currently not

### Are there any user-facing changes?

User can call EqualOptions in RecordBatch

* Closes: apache#34968

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapleFU mapleFU

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34968: [C++] Add Equal Options to RecordBatch mapleFU/arrow
2 participants
@westonpace @mapleFU