-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] RecordBatch support EqualOptions in Equals
and ApproxEquals
#34968
Comments
westonpace
pushed a commit
that referenced
this issue
Apr 11, 2023
### Rationale for this change Currently, directly comparing Array supports EqualOptions, which support nan comparing mode and others. However, array doesn't support passing argument like that. So, it can only use default EqualOptions ### What changes are included in this PR? Add EqualOptions ### Are these changes tested? currently not ### Are there any user-facing changes? User can call EqualOptions in RecordBatch * Closes: #34968 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this issue
May 11, 2023
### Rationale for this change Currently, directly comparing Array supports EqualOptions, which support nan comparing mode and others. However, array doesn't support passing argument like that. So, it can only use default EqualOptions ### What changes are included in this PR? Add EqualOptions ### Are these changes tested? currently not ### Are there any user-facing changes? User can call EqualOptions in RecordBatch * Closes: apache#34968 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this issue
May 15, 2023
### Rationale for this change Currently, directly comparing Array supports EqualOptions, which support nan comparing mode and others. However, array doesn't support passing argument like that. So, it can only use default EqualOptions ### What changes are included in this PR? Add EqualOptions ### Are these changes tested? currently not ### Are there any user-facing changes? User can call EqualOptions in RecordBatch * Closes: apache#34968 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this issue
May 16, 2023
### Rationale for this change Currently, directly comparing Array supports EqualOptions, which support nan comparing mode and others. However, array doesn't support passing argument like that. So, it can only use default EqualOptions ### What changes are included in this PR? Add EqualOptions ### Are these changes tested? currently not ### Are there any user-facing changes? User can call EqualOptions in RecordBatch * Closes: apache#34968 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
Currently, directly comparing
Array
supportsEqualOptions
, which support nan comparing mode and others. However, array doesn't support passing argument like that. So, it can only use defaultEqualOptions
Component(s)
C++
The text was updated successfully, but these errors were encountered: