Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-34968: [C++] Add Equal Options to RecordBatch #34970

Merged
merged 5 commits into from
Apr 11, 2023
Merged

GH-34968: [C++] Add Equal Options to RecordBatch #34970

merged 5 commits into from
Apr 11, 2023

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Apr 7, 2023 •
edited by github-actions bot
Loading

Rationale for this change

Currently, directly comparing Array supports EqualOptions, which support nan comparing mode and others. However, array doesn't support passing argument like that. So, it can only use default EqualOptions

What changes are included in this PR?

Add EqualOptions

Are these changes tested?

currently not

Are there any user-facing changes?

User can call EqualOptions in RecordBatch

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

⚠️ GitHub issue #34968 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member

kou commented Apr 7, 2023

Could you fix a CI failure?

https://github.com/apache/arrow/actions/runs/4639277857/jobs/8209947441?pr=34970#step:6:3002

/arrow/cpp/src/arrow/record_batch.h:107: error: The following parameter of arrow::RecordBatch::ApproxEquals(const RecordBatch &other, const EqualOptions &opts=EqualOptions::Defaults()) const is not documented:
  parameter 'other' (warning treated as error, aborting now)

@mapleFU
Copy link
Member Author

mapleFU commented Apr 8, 2023

Sure, trying to fix it and add test now

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Apr 9, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 10, 2023
@mapleFU
Copy link
Member Author

mapleFU commented Apr 11, 2023

@kou I've fixed all comments. But continuous-integration/appveyor/pr failed, and I don't know why it failed, would you mind take a look?

westonpace
westonpace requested changes Apr 11, 2023
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor nits. I like this change and it looks good. Thanks!

The Appveyor failure is unrelated.

cpp/src/arrow/record_batch.h Outdated Show resolved Hide resolved
cpp/src/arrow/record_batch_test.cc Outdated Show resolved Hide resolved
cpp/src/arrow/record_batch_test.cc Outdated Show resolved Hide resolved
cpp/src/arrow/record_batch_test.cc Outdated Show resolved Hide resolved
cpp/src/arrow/record_batch_test.cc Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes awaiting review Awaiting review and removed awaiting change review Awaiting change review awaiting review Awaiting review awaiting changes Awaiting changes labels Apr 11, 2023
@mapleFU mapleFU force-pushed the record-batch/support-eq-options branch from 5fb2b9d to c38db63 Compare April 11, 2023 17:32
westonpace
westonpace approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround

@westonpace westonpace merged commit 1aedf52 into apache:main Apr 11, 2023
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Apr 11, 2023
@mapleFU mapleFU deleted the record-batch/support-eq-options branch April 12, 2023 02:38
@ursabot
Copy link

ursabot commented Apr 13, 2023

Benchmark runs are scheduled for baseline = 1c06854 and contender = 1aedf52. 1aedf52 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.68% ⬆️0.71%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 1aedf522 ec2-t3-xlarge-us-east-2
[Failed] 1aedf522 test-mac-arm
[Finished] 1aedf522 ursa-i9-9960x
[Failed] 1aedf522 ursa-thinkcentre-m75q
[Finished] 1c06854f ec2-t3-xlarge-us-east-2
[Failed] 1c06854f test-mac-arm
[Finished] 1c06854f ursa-i9-9960x
[Finished] 1c06854f ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@mapleFU @liujiacheng777
apacheGH-34968: [C++] Add Equal Options to RecordBatch (apache#34970)
2c1c08b 
### Rationale for this change

Currently, directly comparing Array supports EqualOptions, which support nan comparing mode and others. However, array doesn't support passing argument like that. So, it can only use default EqualOptions

### What changes are included in this PR?

Add EqualOptions 

### Are these changes tested?

currently not

### Are there any user-facing changes?

User can call EqualOptions in RecordBatch

* Closes: apache#34968

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@mapleFU @ArgusLi
apacheGH-34968: [C++] Add Equal Options to RecordBatch (apache#34970)
95e97a4 
### Rationale for this change

Currently, directly comparing Array supports EqualOptions, which support nan comparing mode and others. However, array doesn't support passing argument like that. So, it can only use default EqualOptions

### What changes are included in this PR?

Add EqualOptions 

### Are these changes tested?

currently not

### Are there any user-facing changes?

User can call EqualOptions in RecordBatch

* Closes: apache#34968

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
@mapleFU @rtpsw
apacheGH-34968: [C++] Add Equal Options to RecordBatch (apache#34970)
b157d69 
### Rationale for this change

Currently, directly comparing Array supports EqualOptions, which support nan comparing mode and others. However, array doesn't support passing argument like that. So, it can only use default EqualOptions

### What changes are included in this PR?

Add EqualOptions 

### Are these changes tested?

currently not

### Are there any user-facing changes?

User can call EqualOptions in RecordBatch

* Closes: apache#34968

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou left review comments

@wgtmac wgtmac wgtmac left review comments

@westonpace westonpace westonpace approved these changes

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C++] RecordBatch support EqualOptions in Equals and ApproxEquals
5 participants
@mapleFU @kou @ursabot @westonpace @wgtmac