-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-35115: [C++] Moved util_avx2.cc from acero to compute #35117
GH-35115: [C++] Moved util_avx2.cc from acero to compute #35117
Conversation
|
Sorry missed this - LGTM |
### Rationale for this change The file util_avx2.cc contains implementation for methods defined in `src/arrow/compute/util.cc` but it was placed in `src/arrow/acero`. This leads to undefined symbol errors when compiling against AVX2. ### What changes are included in this PR? The file util_avx2.cc is moved from `acero` to `compute`. ### Are these changes tested? Regrettably, no. See #35116 ### Are there any user-facing changes? No. * Closes: #35115 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
Benchmark runs are scheduled for baseline = 9824ffc and contender = ae633bc. ae633bc is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
…e#35117) ### Rationale for this change The file util_avx2.cc contains implementation for methods defined in `src/arrow/compute/util.cc` but it was placed in `src/arrow/acero`. This leads to undefined symbol errors when compiling against AVX2. ### What changes are included in this PR? The file util_avx2.cc is moved from `acero` to `compute`. ### Are these changes tested? Regrettably, no. See apache#35116 ### Are there any user-facing changes? No. * Closes: apache#35115 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
…e#35117) ### Rationale for this change The file util_avx2.cc contains implementation for methods defined in `src/arrow/compute/util.cc` but it was placed in `src/arrow/acero`. This leads to undefined symbol errors when compiling against AVX2. ### What changes are included in this PR? The file util_avx2.cc is moved from `acero` to `compute`. ### Are these changes tested? Regrettably, no. See apache#35116 ### Are there any user-facing changes? No. * Closes: apache#35115 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
…e#35117) ### Rationale for this change The file util_avx2.cc contains implementation for methods defined in `src/arrow/compute/util.cc` but it was placed in `src/arrow/acero`. This leads to undefined symbol errors when compiling against AVX2. ### What changes are included in this PR? The file util_avx2.cc is moved from `acero` to `compute`. ### Are these changes tested? Regrettably, no. See apache#35116 ### Are there any user-facing changes? No. * Closes: apache#35115 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
Rationale for this change
The file util_avx2.cc contains implementation for methods defined in
src/arrow/compute/util.cc
but it was placed insrc/arrow/acero
. This leads to undefined symbol errors when compiling against AVX2.What changes are included in this PR?
The file util_avx2.cc is moved from
acero
tocompute
.Are these changes tested?
Regrettably, no. See #35116
Are there any user-facing changes?
No.