Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R][C++] Fixed shape tensor causes broken build on OSX #35143

Closed
paleolimbot opened this issue Apr 14, 2023 · 0 comments · Fixed by #35154
Closed

[R][C++] Fixed shape tensor causes broken build on OSX #35143

paleolimbot opened this issue Apr 14, 2023 · 0 comments · Fixed by #35154
Assignees
@rok
Labels
Component: C++ Component: R Priority: Blocker Marks a blocker for the release Type: bug
Milestone
12.0.0

Comments

@paleolimbot
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

https://github.com/ursacomputing/crossbow/actions/runs/4697955246/jobs/8330105114#step:13:6683

/Users/voltrondata/tmp/hbtmp/apache-arrow-20230414-81534-1kxxt58/cpp/src/arrow/extension/fixed_shape_tensor.cc:271:15: error: no member named 'reinterpret_pointer_cast' in namespace 'std'
  return std::reinterpret_pointer_cast<FixedShapeTensorArray>(ext_arr);
         ~~~~~^
/Users/voltrondata/tmp/hbtmp/apache-arrow-20230414-81534-1kxxt58/cpp/src/arrow/extension/fixed_shape_tensor.cc:271:40: error: 'FixedShapeTensorArray' does not refer to a value
  return std::reinterpret_pointer_cast<FixedShapeTensorArray>(ext_arr);
                                       ^
/Users/voltrondata/tmp/hbtmp/apache-arrow-20230414-81534-1kxxt58/cpp/src/arrow/extension/fixed_shape_tensor.h:23:20: note: declared here
class ARROW_EXPORT FixedShapeTensorArray : public ExtensionArray {
                   ^

Component(s)

R
@paleolimbot paleolimbot added Priority: Blocker Marks a blocker for the release and removed Component: R labels Apr 14, 2023
@paleolimbot paleolimbot added this to the 12.0.0 milestone Apr 14, 2023
@rok rok mentioned this issue Apr 15, 2023
Merged
paleolimbot pushed a commit that referenced this issue Apr 17, 2023
@rok
GH-35143: [R][C++] Fixed shape tensor causes broken build on OSX (#35154
5605cf5 
)

### Rationale for this change

`std::reinterpret_pointer_cast` was introduced with FixedShapeTensor PR (#34797) but is not available on OSX (see #35143).

### What changes are included in this PR?

This change switches to using `internal::checked_pointer_cast`.

### Are these changes tested?

Change is tested in CI, but should also be verified on crossbow.

### Are there any user-facing changes?

No.
* Closes: #35143

Authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Dewey Dunnington <dewey@voltrondata.com>
raulcd pushed a commit that referenced this issue Apr 17, 2023
@rok @raulcd
GH-35143: [R][C++] Fixed shape tensor causes broken build on OSX (#35154
450caf2 
)

### Rationale for this change

`std::reinterpret_pointer_cast` was introduced with FixedShapeTensor PR (#34797) but is not available on OSX (see #35143).

### What changes are included in this PR?

This change switches to using `internal::checked_pointer_cast`.

### Are these changes tested?

Change is tested in CI, but should also be verified on crossbow.

### Are there any user-facing changes?

No.
* Closes: #35143

Authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Dewey Dunnington <dewey@voltrondata.com>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@rok @liujiacheng777
apacheGH-35143: [R][C++] Fixed shape tensor causes broken build on OSX (
e07617e 
apache#35154)

### Rationale for this change

`std::reinterpret_pointer_cast` was introduced with FixedShapeTensor PR (apache#34797) but is not available on OSX (see apache#35143).

### What changes are included in this PR?

This change switches to using `internal::checked_pointer_cast`.

### Are these changes tested?

Change is tested in CI, but should also be verified on crossbow.

### Are there any user-facing changes?

No.
* Closes: apache#35143

Authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Dewey Dunnington <dewey@voltrondata.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@rok @ArgusLi
apacheGH-35143: [R][C++] Fixed shape tensor causes broken build on OSX (
90fbbb4 
apache#35154)

### Rationale for this change

`std::reinterpret_pointer_cast` was introduced with FixedShapeTensor PR (apache#34797) but is not available on OSX (see apache#35143).

### What changes are included in this PR?

This change switches to using `internal::checked_pointer_cast`.

### Are these changes tested?

Change is tested in CI, but should also be verified on crossbow.

### Are there any user-facing changes?

No.
* Closes: apache#35143

Authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Dewey Dunnington <dewey@voltrondata.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@rok @rtpsw
apacheGH-35143: [R][C++] Fixed shape tensor causes broken build on OSX (
2d5cdee 
apache#35154)

### Rationale for this change

`std::reinterpret_pointer_cast` was introduced with FixedShapeTensor PR (apache#34797) but is not available on OSX (see apache#35143).

### What changes are included in this PR?

This change switches to using `internal::checked_pointer_cast`.

### Are these changes tested?

Change is tested in CI, but should also be verified on crossbow.

### Are there any user-facing changes?

No.
* Closes: apache#35143

Authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Dewey Dunnington <dewey@voltrondata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rok rok

Labels
Component: C++ Component: R Priority: Blocker Marks a blocker for the release Type: bug
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-35143: [R][C++] Fixed shape tensor causes broken build on OSX rok/arrow
2 participants
@rok @paleolimbot