GH-35143: [R][C++] Fixed shape tensor causes broken build on OSX #35154
Conversation
|
|
github-actions
bot
added
Component: C++
awaiting committer review
rok
force-pushed
the
35143
branch
2 times, most recently
from
ec88927
to
e3ef8ff
Compare
|
@github-actions crossbow submit verify-rc-source-cpp-macos-* |
|
Revision: 75a091f Submitted crossbow builds: ursacomputing/crossbow @ actions-2d2b1993f0
|
|
@github-actions crossbow submit r-binary-packages |
|
Revision: 75a091f Submitted crossbow builds: ursacomputing/crossbow @ actions-f9fd62314b
|
|
@github-actions crossbow submit r-binary-packages |
|
Revision: 75a091f Submitted crossbow builds: ursacomputing/crossbow @ actions-c5fa4612d6
|
|
@paleolimbot mac builds now pass. |
github-actions
bot
added
awaiting merge
) ### Rationale for this change `std::reinterpret_pointer_cast` was introduced with FixedShapeTensor PR (#34797) but is not available on OSX (see #35143). ### What changes are included in this PR? This change switches to using `internal::checked_pointer_cast`. ### Are these changes tested? Change is tested in CI, but should also be verified on crossbow. ### Are there any user-facing changes? No. * Closes: #35143 Authored-by: Rok Mihevc <rok@mihevc.org> Signed-off-by: Dewey Dunnington <dewey@voltrondata.com>
|
Benchmark runs are scheduled for baseline = 94b3423 and contender = 5605cf5. 5605cf5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
apache#35154) ### Rationale for this change `std::reinterpret_pointer_cast` was introduced with FixedShapeTensor PR (apache#34797) but is not available on OSX (see apache#35143). ### What changes are included in this PR? This change switches to using `internal::checked_pointer_cast`. ### Are these changes tested? Change is tested in CI, but should also be verified on crossbow. ### Are there any user-facing changes? No. * Closes: apache#35143 Authored-by: Rok Mihevc <rok@mihevc.org> Signed-off-by: Dewey Dunnington <dewey@voltrondata.com>
apache#35154) ### Rationale for this change `std::reinterpret_pointer_cast` was introduced with FixedShapeTensor PR (apache#34797) but is not available on OSX (see apache#35143). ### What changes are included in this PR? This change switches to using `internal::checked_pointer_cast`. ### Are these changes tested? Change is tested in CI, but should also be verified on crossbow. ### Are there any user-facing changes? No. * Closes: apache#35143 Authored-by: Rok Mihevc <rok@mihevc.org> Signed-off-by: Dewey Dunnington <dewey@voltrondata.com>
apache#35154) ### Rationale for this change `std::reinterpret_pointer_cast` was introduced with FixedShapeTensor PR (apache#34797) but is not available on OSX (see apache#35143). ### What changes are included in this PR? This change switches to using `internal::checked_pointer_cast`. ### Are these changes tested? Change is tested in CI, but should also be verified on crossbow. ### Are there any user-facing changes? No. * Closes: apache#35143 Authored-by: Rok Mihevc <rok@mihevc.org> Signed-off-by: Dewey Dunnington <dewey@voltrondata.com>
Rationale for this change
std::reinterpret_pointer_castwas introduced with FixedShapeTensor PR (#34797) but is not available on OSX (see #35143).What changes are included in this PR?
This change switches to using
internal::checked_pointer_cast.Are these changes tested?
Change is tested in CI, but should also be verified on crossbow.
Are there any user-facing changes?
No.