Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Dataframe interchange protocol updates after pandas bug fixes #35264

Closed
4 tasks done
AlenkaF opened this issue Apr 21, 2023 · 0 comments · Fixed by #35530
Closed
4 tasks done

[Python] Dataframe interchange protocol updates after pandas bug fixes #35264

AlenkaF opened this issue Apr 21, 2023 · 0 comments · Fixed by #35530
Assignees
@AlenkaF
Labels
Component: Python good-first-issue Type: enhancement
Milestone
13.0.0

Comments

@AlenkaF
Copy link
Member

AlenkaF commented Apr 21, 2023 •
edited

Describe the enhancement requested

This issue is meant to include all the updates needed in the dataframe interchange protocol implementation (mainly in tests) as bugs in the pandas implementation are getting fixed:

TODO list:

Component(s)

Python
@github-actions github-actions bot mentioned this issue May 10, 2023
Merged
@AlenkaF AlenkaF self-assigned this May 10, 2023
jorisvandenbossche pushed a commit that referenced this issue May 11, 2023
@AlenkaF
GH-35264: [Python] Interchange protocol: test clean-up (#35530)
14f9bf9 
The diff is a bit confusing so I will add some notes here:

- `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*`
- the skip for the `test_pandas_roundtrip_categorical` is removed
- `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical`
- `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip`
- `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in #35504
* Closes: #35264

Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jorisvandenbossche jorisvandenbossche added this to the 13.0.0 milestone May 11, 2023
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@AlenkaF @ArgusLi
apacheGH-35264: [Python] Interchange protocol: test clean-up (apache#…
bcceaff 
…35530)

The diff is a bit confusing so I will add some notes here:

- `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*`
- the skip for the `test_pandas_roundtrip_categorical` is removed
- `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical`
- `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip`
- `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in apache#35504
* Closes: apache#35264

Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@AlenkaF @rtpsw
apacheGH-35264: [Python] Interchange protocol: test clean-up (apache#…
2233974 
…35530)

The diff is a bit confusing so I will add some notes here:

- `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*`
- the skip for the `test_pandas_roundtrip_categorical` is removed
- `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical`
- `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip`
- `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in apache#35504
* Closes: apache#35264

Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlenkaF AlenkaF

Labels
Component: Python good-first-issue Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35264: [Python] Interchange protocol: test clean-up AlenkaF/arrow
2 participants
@jorisvandenbossche @AlenkaF