GH-35264: [Python] Interchange protocol: test clean-up #35530
Conversation
|
@github-actions crossbow submit test-conda-python--pandas- |
| if Version(pd.__version__) < Version("1.5.0"): | ||
| pytest.skip("__dataframe__ added to pandas in 1.5.0") | ||
| def test_pandas_roundtrip_categorical(): | ||
| if Version(pd.__version__) < Version("2.0.2"): |
There was a problem hiding this comment.
Should the pandas version for skipping tests due to Column.size() bug in pandas match between tests test_pandas_roundtrip_string (v2.0.1) and test_pandas_roundtrip_categorical (v2.0.2)?
There was a problem hiding this comment.
Good catch! =) There are also bitmasks involved here, so I have to change the skip message 😊
There was a problem hiding this comment.
I have, unfortunately, added this change in the rebasing process and is therefore not visible in the commit history.
The change can be seen here:
arrow/python/pyarrow/tests/interchange/test_conversion.py
Lines 243 to 245 in 0e74ace
|
Added one comment, but besides that LGTM! |
|
This needs a rebase now I merged the other PR |
AlenkaF
force-pushed
the
gh-35264-interchange-test-updates
branch
from
b3dafde
to
0e74ace
Compare
github-actions
bot
added
awaiting committer review
|
@github-actions crossbow submit test-conda-python--pandas- |
|
Revision: 0e74ace Submitted crossbow builds: ursacomputing/crossbow @ actions-894d083930
|
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting merge
|
Benchmark runs are scheduled for baseline = b36ff71 and contender = 14f9bf9. 14f9bf9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…35530) The diff is a bit confusing so I will add some notes here: - `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*` - the skip for the `test_pandas_roundtrip_categorical` is removed - `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical` - `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip` - `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in apache#35504 * Closes: apache#35264 Authored-by: Alenka Frim <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
…35530) The diff is a bit confusing so I will add some notes here: - `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*` - the skip for the `test_pandas_roundtrip_categorical` is removed - `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical` - `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip` - `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in apache#35504 * Closes: apache#35264 Authored-by: Alenka Frim <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
The diff is a bit confusing so I will add some notes here:
test_categorical_roundtripis not removed but renamed totest_pandas_roundtrip_categoricalso that all tests checkingpyarrow->pandas->pyarrowstart withtest_pandas_roundtip_*test_pandas_roundtrip_categoricalis removedtest_pandas_to_pyarrow_categorical_with_missingis removed as the conversion for categorical with missing values is now checked intest_pandas_roundtrip_categoricaltest_roundtrip_pandas_booleanis removed and the check for boolean has been added totest_pandas_roundtriptest_pandas_assertion_error_large_stringandtest_pandas_to_pyarrow_string_with_missingare removed as the update for these is done separately in GH-35490: [Python] Interchange protocol: update tests for string and large_string #35504