GH-35490: [Python] Interchange protocol: update tests for string and large_string #35504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
awaiting changes
|
Oh yes, of course! Will correct 👍 |
github-actions
bot
added
awaiting change review
github-actions
bot
added
awaiting changes
|
@github-actions crossbow submit test-conda-python--pandas- |
|
Revision: 0179e1c Submitted crossbow builds: ursacomputing/crossbow @ actions-d113313268
|
AlenkaF
force-pushed
the
gh-35490-interchange-large-string
branch
from
0179e1c
to
5f05027
Compare
|
@github-actions crossbow submit test-conda-python--pandas- |
|
Revision: 5f05027 Submitted crossbow builds: ursacomputing/crossbow @ actions-6f1dfae313
|
This was referenced May 10, 2023
jorisvandenbossche
approved these changes
May 11, 2023
github-actions
bot
added
awaiting merge
|
Nightly failure is unrelated (but something else we should fix) |
I think this failure is connected to #34789? |
|
Yes, indeed, I am looking at that |
jorisvandenbossche
pushed a commit
that referenced
this pull request
May 11, 2023
The diff is a bit confusing so I will add some notes here: - `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*` - the skip for the `test_pandas_roundtrip_categorical` is removed - `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical` - `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip` - `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in #35504 * Closes: #35264 Authored-by: Alenka Frim <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
|
Benchmark runs are scheduled for baseline = 11780b9 and contender = dec4453. dec4453 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
…g and large_string (apache#35504) ### Rationale for this change In pandas version 2.0.1 the interchange protocol implementation has support for large strings. The tests on our side need to be updated accordingly. ### What changes are included in this PR? Changes in tests: - `test_pandas_assertion_error_large_string` removed - `test_roundtrip_pandas_string ` updated * Closes: apache#35490 Authored-by: Alenka Frim <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
…35530) The diff is a bit confusing so I will add some notes here: - `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*` - the skip for the `test_pandas_roundtrip_categorical` is removed - `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical` - `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip` - `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in apache#35504 * Closes: apache#35264 Authored-by: Alenka Frim <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this pull request
May 16, 2023
…g and large_string (apache#35504) ### Rationale for this change In pandas version 2.0.1 the interchange protocol implementation has support for large strings. The tests on our side need to be updated accordingly. ### What changes are included in this PR? Changes in tests: - `test_pandas_assertion_error_large_string` removed - `test_roundtrip_pandas_string ` updated * Closes: apache#35490 Authored-by: Alenka Frim <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this pull request
May 16, 2023
…35530) The diff is a bit confusing so I will add some notes here: - `test_categorical_roundtrip` is not removed but renamed to `test_pandas_roundtrip_categorical` so that all tests checking `pyarrow` -> `pandas` -> `pyarrow` start with `test_pandas_roundtip_*` - the skip for the `test_pandas_roundtrip_categorical` is removed - `test_pandas_to_pyarrow_categorical_with_missing` is removed as the conversion for categorical with missing values is now checked in `test_pandas_roundtrip_categorical` - `test_roundtrip_pandas_boolean` is removed and the check for boolean has been added to `test_pandas_roundtrip` - `test_pandas_assertion_error_large_string` and `test_pandas_to_pyarrow_string_with_missing` are removed as the update for these is done separately in apache#35504 * Closes: apache#35264 Authored-by: Alenka Frim <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
In pandas version 2.0.1 the interchange protocol implementation has support for large strings. The tests on our side need to be updated accordingly.
What changes are included in this PR?
Changes in tests:
test_pandas_assertion_error_large_stringremovedtest_roundtrip_pandas_stringupdated