Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-37456: [R] CRAN incoming checks show NOTE due to internal function which isn't documented #37457

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

thisisnic
Copy link
Member

@thisisnic thisisnic commented Aug 30, 2023

Rationale for this change

Failed CRAN check due to updates to their checks on R-devel

What changes are included in this PR?

Add additional roxygen header

Are these changes tested?

No

Are there any user-facing changes?

No

@thisisnic thisisnic changed the title GH-37456: [R] CRAN incoming checks show NOTE due to internal function which isn't documented # GH-37456: [R] CRAN incoming checks show NOTE due to internal function which isn't documented Aug 30, 2023
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Just double-checking that this doesn't need a devtools::document() (I forget whether or not these roxygen tags affect that).

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Aug 30, 2023
@thisisnic thisisnic added the Priority: Blocker Marks a blocker for the release label Aug 31, 2023
@thisisnic thisisnic added this to the 14.0.0 milestone Aug 31, 2023
@thisisnic thisisnic merged commit 58c2c37 into apache:main Aug 31, 2023
9 of 11 checks passed
@thisisnic thisisnic removed the awaiting merge Awaiting merge label Aug 31, 2023
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 58c2c37.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…nction which isn't documented (apache#37457)

### Rationale for this change

Failed CRAN check due to updates to their checks on R-devel

### What changes are included in this PR?

Add additional roxygen header

### Are these changes tested?

No

### Are there any user-facing changes?

No
* Closes: apache#37456

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…nction which isn't documented (apache#37457)

### Rationale for this change

Failed CRAN check due to updates to their checks on R-devel

### What changes are included in this PR?

Add additional roxygen header

### Are these changes tested?

No

### Are there any user-facing changes?

No
* Closes: apache#37456

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: R Priority: Blocker Marks a blocker for the release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[R] CRAN incoming checks show NOTE due to internal function which isn't documented
2 participants