-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-37456: [R] CRAN incoming checks show NOTE due to internal function which isn't documented #37457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Just double-checking that this doesn't need a devtools::document()
(I forget whether or not these roxygen tags affect that).
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 58c2c37. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
…nction which isn't documented (apache#37457) ### Rationale for this change Failed CRAN check due to updates to their checks on R-devel ### What changes are included in this PR? Add additional roxygen header ### Are these changes tested? No ### Are there any user-facing changes? No * Closes: apache#37456 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
…nction which isn't documented (apache#37457) ### Rationale for this change Failed CRAN check due to updates to their checks on R-devel ### What changes are included in this PR? Add additional roxygen header ### Are these changes tested? No ### Are there any user-facing changes? No * Closes: apache#37456 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
Rationale for this change
Failed CRAN check due to updates to their checks on R-devel
What changes are included in this PR?
Add additional roxygen header
Are these changes tested?
No
Are there any user-facing changes?
No